Fixed connect under reset for st-flash and st-util #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adrienbruant: That's very attentive - Thank you. 👍 |
Nightwalker-87
changed the title
|
@Nightwalker-87 Sorry, are you asking me to review these issues ? I'm afraid I don't have time and my understanding of stlink is superficial. I saw a quick fix for something that was bugging me, but I can't offer much more. That's my first PR ever on a public project, sorry if it's not proper etiquette. |
|
No, you are fine with that and only assigned to this PR as you are the author. |
Nightwalker-87
approved these changes
Jun 15, 2020
Nightwalker-87
added
status/resolved
and removed
needs/investigation
needs/testing
labels
Nightwalker-87
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for the connect under reset feature on st-util and st-flash. This feature was added in a previous pull request (#963) but there was a missing connection between the CLI and the library.