Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added call to clear PG bit after Writing to Flash #773

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Added call to clear PG bit after Writing to Flash #773

merged 1 commit into from
Mar 7, 2019

Conversation

ronnymajani
Copy link
Contributor

The st-flash write utility wasn't clearing the PG bit after it finished writing to Flash.
Luckily you've already implemented the function for clearing the PG bit, so I just added the call right before locking Flash CR again.
The reason this is important is that if I just flashed a firmware, then any subsequent operation will fail, until I clear the PG bit, so I'll have to add code just for that one case. Or a simple power cycle the STM32 clears it.
Anyway it's just a convenience for the flasher utility to clean up after itself :)

@xor-gate xor-gate added this to the Next milestone Mar 7, 2019
@xor-gate xor-gate merged commit 522188d into stlink-org:master Mar 7, 2019
@xor-gate
Copy link
Member

xor-gate commented Mar 7, 2019

Thanks @ronnymajani !

@Nightwalker-87 Nightwalker-87 removed this from the General milestone Feb 21, 2020
@Nightwalker-87 Nightwalker-87 self-assigned this Feb 21, 2020
@Nightwalker-87 Nightwalker-87 added this to the v1.6.0 milestone Feb 21, 2020
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants