Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make udev rules and modprobe conf installation optional #741

Merged

Conversation

g-arjones
Copy link
Contributor

No description provided.

@g-arjones
Copy link
Contributor Author

Ping? @texane @xor-gate @karlp

@xor-gate
Copy link
Member

It seems you have broken the build for all platforms with cmake ~v3.0: https://travis-ci.org/texane/stlink/jobs/443197492#L1021

@g-arjones
Copy link
Contributor Author

It seems like this was happening before my patch: https://travis-ci.org/texane/stlink/jobs/428338176#L1014

See build history for more occurrences..

Problem is in this line:

https://github.com/texane/stlink/blob/7fafee24a57c4cfa24df56383546d5c04866b512/CMakeLists.txt#L121

Which is unrelated to changes I introduced.. or am I missing something?

@xor-gate
Copy link
Member

Aah sorry for the delay, i was unaware some other change had broken the build. Thank you for the contribution.

@xor-gate xor-gate merged commit 8c46827 into stlink-org:master Oct 24, 2018
@Nightwalker-87 Nightwalker-87 self-assigned this Feb 21, 2020
@Nightwalker-87 Nightwalker-87 added this to the v1.6.0 milestone Feb 21, 2020
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants