For Issue 726, Semihost SYS_READ returns incorrect value on EOF #727
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calculation of *ret for EOF case.
|
Great, looks like a good fix! Thanks for your PR. |
6 tasks
|
I agree with Fabien-Chouteau's review items. Thanks for catching my sloppy errors. I'll submit another PR shortly (after I check it myself one more time). |
donmr
added a commit
to donmr/stlink
that referenced
this pull request
Jul 27, 2018
xor-gate
pushed a commit
that referenced
this pull request
Jul 28, 2018
* Use local variable for read_result instead of *ret, and fix calculation of *ret for EOF case. * Found a problem when reading an odd (%4) number of bytes at the end of a file. fread (on stm32) get them (say 3 bytes), then askes for more. do_semihosting gets a read return of 0 and tries to write that. mem_write alters the address to be aligned and overwrites then 3 bytes from the last read. This change simply tells mem_write to do nothing if len is 0. * Fix Issues from Fabien-Chouteau's review of my previous patch in isue #727. * Revert change to mem_write() so it does not confuse fixes to do_semihosting(). * Add cast to avoid warning.
donmr
added a commit
to donmr/stlink
that referenced
this pull request
Jul 28, 2018
Fixes to SYS_READ changes in PR stlink-org#727 per review. (stlink-org#729)
donmr
added a commit
to donmr/stlink
that referenced
this pull request
Jul 28, 2018
Fixes to SYS_READ changes in PR stlink-org#727 per review. (stlink-org#729)
xor-gate
pushed a commit
that referenced
this pull request
Aug 1, 2018
* Use local variable for read_result instead of *ret, and fix calculation of *ret for EOF case. * Found a problem when reading an odd (%4) number of bytes at the end of a file. fread (on stm32) get them (say 3 bytes), then askes for more. do_semihosting gets a read return of 0 and tries to write that. mem_write alters the address to be aligned and overwrites then 3 bytes from the last read. This change simply tells mem_write to do nothing if len is 0. * Fix Issues from Fabien-Chouteau's review of my previous patch in isue #727. * Revert change to mem_write() so it does not confuse fixes to do_semihosting(). * Add cast to avoid warning. * Restore change to mem_write to return immeadiately if len == 0. Add more comments on further possible issues and ways to handle them. Using a branch to separate this change from others as it may need more discussion and go on for a while... * Remove cast of "-1" to uint32_t. It's now compared to a ssize_t and the compiler should be fine with that without any cast.
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use local variable for read_result instead of *ret, and fix calculation of *ret for EOF case.