Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stm32l432 support #501

Merged
merged 2 commits into from
Oct 15, 2016
Merged

stm32l432 support #501

merged 2 commits into from
Oct 15, 2016

Conversation

geoffreymbrown
Copy link
Collaborator

Changes to support stm32l432

Copy link
Member

@xor-gate xor-gate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except those two minor comment

include/stlink/chipid.h Show resolved Hide resolved
src/chipid.c Show resolved Hide resolved
@geoffreymbrown
Copy link
Collaborator Author

Ok. Do you want me to correct the whitespace ? Or is it easier for you to
handle ?
Geoffrey

On Sat, Oct 15, 2016 at 2:41 PM, Jerry Jacobs [email protected]
wrote:

@xor-gate requested changes on this pull request.

Looks good, except those two minor comment

In include/stlink/chipid.h
#501 (review):

@@ -54,6 +55,9 @@ enum stlink_stm32_chipids {
STLINK_CHIPID_STM32_F7 = 0x449,
STLINK_CHIPID_STM32_F7XXXX = 0x451,
STLINK_CHIPID_STM32_F410 = 0x458
+
+

Please dont add whitespaces

In src/chipid.c
#501 (review):

@@ -406,6 +406,22 @@ static const struct stlink_chipid_params devices[] = {
.bootrom_base = 0x1fff0000, // Tables 4-6, pages 80-81 (Bank 1 system memory)
.bootrom_size = 0x7000 // 28k (per bank), same source as base
},

  •     {
    
  •        //   STLINK_CHIPID_STM32_L43X
    
  •        // From RM0392.
    
  •     .chip_id = STLINK_CHIPID_STM32_L43X,
    
  •        .description = "L4 device",
    

L43x device


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#501 (review), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABq_UmJvVJr5T7zKoLpdcM3Bvt8Aax4vks5q0R5AgaJpZM4KXx2L
.

@geoffreymbrown
Copy link
Collaborator Author

ok, I've pushed the changes -- looks like they show up in the pull request.
Geoffrey

On Sat, Oct 15, 2016 at 2:43 PM, Geoffrey Brown [email protected]
wrote:

Ok. Do you want me to correct the whitespace ? Or is it easier for you
to handle ?
Geoffrey

On Sat, Oct 15, 2016 at 2:41 PM, Jerry Jacobs [email protected]
wrote:

@xor-gate requested changes on this pull request.

Looks good, except those two minor comment

In include/stlink/chipid.h
#501 (review):

@@ -54,6 +55,9 @@ enum stlink_stm32_chipids {
STLINK_CHIPID_STM32_F7 = 0x449,
STLINK_CHIPID_STM32_F7XXXX = 0x451,
STLINK_CHIPID_STM32_F410 = 0x458
+
+

Please dont add whitespaces

In src/chipid.c
#501 (review):

@@ -406,6 +406,22 @@ static const struct stlink_chipid_params devices[] = {
.bootrom_base = 0x1fff0000, // Tables 4-6, pages 80-81 (Bank 1 system memory)
.bootrom_size = 0x7000 // 28k (per bank), same source as base
},

  •        {
    
  •        //  STLINK_CHIPID_STM32_L43X
    
  •        // From RM0392.
    
  •    .chip_id = STLINK_CHIPID_STM32_L43X,
    
  •        .description = "L4 device",
    

L43x device


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#501 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABq_UmJvVJr5T7zKoLpdcM3Bvt8Aax4vks5q0R5AgaJpZM4KXx2L
.

@xor-gate xor-gate added this to the v1.3.0 milestone Oct 15, 2016
@xor-gate xor-gate merged commit f80412c into stlink-org:master Oct 15, 2016
@xor-gate
Copy link
Member

Yes all changes in a separate branch go into the same pull request. Thank you!

@geoffreymbrown geoffreymbrown deleted the stm32l432support branch October 15, 2016 20:31
@Nightwalker-87 Nightwalker-87 linked an issue Mar 17, 2020 that may be closed by this pull request
6 tasks
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for stm32l432 nucleo
3 participants