Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packaging: Improvements to debian package build. #473

Closed
wants to merge 4 commits into from
Closed

packaging: Improvements to debian package build. #473

wants to merge 4 commits into from

Conversation

OsterlaD
Copy link
Contributor

Solution to problems with debian package build issue.

@xor-gate
Copy link
Member

xor-gate commented Sep 18, 2016 •
edited
Loading

You should not rely on the build/Debug/doc/man/*.1 because this only used during building debug targets (developers). Debian package should use only Release targets and fetch the pre-generated man-pages from doc/man/*.1.

@xor-gate
Copy link
Member

See here: https://github.com/texane/stlink/blob/cmake-fixes/doc/man/CMakeLists.txt#L9

@OsterlaD OsterlaD mentioned this pull request Sep 18, 2016
Closed
2 tasks
@xor-gate
Copy link
Member

I have merged cmake-fixes into master, you may rebase to master which builds again. Travis building broke for some unknown reason and I have hardened the cmake version detection now.

@OsterlaD OsterlaD force-pushed the master branch 2 times, most recently from 8af7ae0 to 74fc31d Compare September 18, 2016 14:22
@OsterlaD
Copy link
Contributor Author

Reworked patch stack on master.
Now manpages contains doc/man/st-.1 entry, corresponding to install entry usr/bin/st-.
The debian/copyright file indicates BSD-3-clause license with copyright holders from LICENSE file.

@OsterlaD
Copy link
Contributor Author

Added udev rules and modprobe installation rules.

@xor-gate
Copy link
Member

Could you squash-merge all your commits into one? Then we are ready to go!

@OsterlaD
Copy link
Contributor Author

There are still some issues.

  • manpages expect to install from source, not build direcotry or debian/tmp, but the nice man pages are created from *.md files and were placed under build/Debug/doc/man
  • stlink-gui requires src/tools/gui/stlink-gui.ui file and seems to expect it under /usr/local/share/stlink
  • is it correct to build debug variant?

@xor-gate
Copy link
Member

xor-gate commented Sep 19, 2016 •
edited
Loading

I will comment inline:

  • manpages expect to install from source, not build direcotry or debian/tmp, but the nice man pages are created from *.md files and were placed under build/Debug/doc/man

Package maintainers should only use the generated manpages from doc/man/*.1 texane has put the missing generated roff files there in latest master. This takes away the pandoc dependency for package maintainers. See 043a928

  • stlink-gui requires src/tools/gui/stlink-gui.ui file and seems to expect it under /usr/local/share/stlink

This is hardcoded into the GUI currently and it has not fixed yet.

  • is it correct to build debug variant?

The Debug target is not what you want in a package, because it contains debug symbols (GDB) and is not optimized (-O0).

@OsterlaD OsterlaD closed this Sep 19, 2016
c-mauderer and others added 4 commits October 16, 2016 10:41
@c-mauderer
cmake: Fix location of modprobe.d config.
880c6f7
@c-mauderer
cmake: Use prefix for udev rules.
199bbba 
Arch Linux doesn't have a /lib any longer. Therefore
the udev rules must not be installed there.
@c-mauderer
cmake: Use cmake variables for install locations.
4b488ac 
This commit add the following two Cmake variables to
change the install location of the udev and modprobe
configuration files:
    - STLINK_UDEV_RULES_DIR
    - STLINK_MODPROBED_DIR
@OsterlaD
debian: Adapt install file to move udev rules from etc to lib dir.
f217838
@Nightwalker-87 Nightwalker-87 added this to the v1.6.1 milestone Mar 17, 2020
@Nightwalker-87 Nightwalker-87 changed the title Improvements to debian package build. packaging: Improvements to debian package build. Mar 17, 2020
@Nightwalker-87 Nightwalker-87 linked an issue Mar 17, 2020 that may be closed by this pull request
packaging: Problems with debian package generation #472
Closed
2 tasks
@Nightwalker-87 Nightwalker-87 changed the base branch from master to develop March 17, 2020 12:20
@Nightwalker-87 Nightwalker-87 modified the milestones: v1.6.1, v1.3.0 Mar 17, 2020
@Nightwalker-87 Nightwalker-87 changed the base branch from develop to master March 17, 2020 12:33
@Nightwalker-87
Copy link
Member

Closed in favour of #484.

@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug/fixed bug/packaging os/linux status/resolved status/withdrawn
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

packaging: Problems with debian package generation
4 participants
@OsterlaD @xor-gate @Nightwalker-87 @c-mauderer