"[!] send_recv" error message is a little cryptic

[galexander1]

To diagnose a recent problem (#423), I found screens full of "[!] send_recv", which was not meaningful to me - I could not even be certain it was an error message. Pull request forthcoming.

[galexander1]

I made pull request #426 to address this issue. When the send_recv() fails, now it outputs the libusb error name and what it was trying to do (send request/read reply) when the failure happened. And when the caller notices send_recv() failed, it also outputs the STLINK_... command name that it was attempting. Makes it particularly easy to unambiguously diagnose when one stage in stlink access causes future requests to fail.

[xor-gate]

Hi @galexander1 looks very good to me. @texane could you also review the PR #426? You may merge this after review.

[texane]

sorry for delay, but looks good to me too

2016-06-05 20:37 GMT+02:00 Jerry Jacobs [email protected]:

Closed #425 #425.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#425 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAEeH_5QzgO5BGqzkJkARzplfzeiGvKsks5qIxd2gaJpZM4IuNSP
.

[xor-gate]

Good, so my "silent" merge effort is not lost :=)

[texane]

Of course it is not :)

2016-06-05 20:45 GMT+02:00 Jerry Jacobs [email protected]:

Good, so my "silent" merge effort is not lost :=)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#425 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAEeH59OSL9yTD_IN5epxBe-9HNf3Qusks5qIxlagaJpZM4IuNSP
.