-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Improved support for writing option bytes #1102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
option byte wirte does not work, parameter is not forwarded |
tested on chip id 0x0413 |
@2a17 Yes, сorrections in the right direction. Writing option byte have bug now (not work). But it is worth paying attention to write code: Lines 182 to 193 in cc9bedd
Parsing needs to be simplify by remove unused parameters (filename and addr) |
Nightwalker-87
approved these changes
Mar 13, 2021
Ant-ON
approved these changes
Mar 14, 2021
Nightwalker-87
approved these changes
Mar 14, 2021
Nightwalker-87
changed the title
option byte support improved
Improved support for writing option bytes
Mar 14, 2021
Nightwalker-87
changed the title
Improved support for writing option bytes
Fix: Improved support for writing option bytes
Mar 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Closes #1128)