stlink.pc not installed

[Vascom]

Time for next bugreport :)

Now stlink.pc file not installed at all.

It should be installed to /usr/lib64/pkgconfig/
lib64 - current libdir.

[Nightwalker-87]

Possible, as package configuration is rewritten currently.
The whole procedure is refactored, so don't bother about it too much yet.
I just did not open a separate ticket for it as I am working on it myself...
Please stay with fc72b92 if you need a working old configuration. If you find the same there, then it is an older problem not related to current changes.

[Nightwalker-87]

@Vascom: Can you test the current pkg branch now and report back?

[Vascom]

One moment.

[Vascom]

stlink.pc not installed at all.
Are you forgot add cmake/pkgconfig to main CMakeLists.txt?
Full build log https://paste.centos.org/view/b4546f4d

[Nightwalker-87]

Don't expect it to work on the develop branch, changes were only made on the latest pkg branch.
Should it not work there, then I have no clue, sry.

[Nightwalker-87]

Something is not right at your end, at least. The version string reads 1.6.1 which is not present yet. I don't know where your build routine got this from. It should still be 1.6.0. The former has not been defined anywhere in the code yet.

[Vascom]

Do you mean stlink-1.6.1-0.1.20200420git78dd836?
It is version in my spec file. It is not affect build.

[Nightwalker-87]

I know it does not affect the build, but I knew it was not from the provided settings. However I can't figure out the problem right now. So I suggest you stay on the old version for know or look into the details yourself. I never had any error on this so far on my system. (I doubt though these settings are even used on debian-based systems. If so, then my build system has no problem with it.)

[Vascom]

To be as in 1.6.0 you should

1. Copy https://raw.githubusercontent.com/stlink-org/stlink/v1.6.0/usr/lib/pkgconfig/CMakeLists.txt to cmake/pkgconfig/ and replace existing CMakeLists.txt there.
2. Copy https://raw.githubusercontent.com/stlink-org/stlink/v1.6.0/usr/lib/pkgconfig/pkg-config.pc.cmake to cmake/pkgconfig/ and remove pkgconfig.pc.cmake.
3. Add add_subdirectory(cmake/pkgconfig) to main CMakeLists.txt.

With this change all work.

[Nightwalker-87]

Try the new version, it is not exactly the same though as you propose.

[Vascom]

Looks good and work.

But may be at x86_64 this
libdir=${prefix}/lib/${deb_host_multiarch}
must be
libdir=${prefix}/lib64/${deb_host_multiarch}

I am not sure.

[Nightwalker-87]

No, because the tools still build a 32-bit library, also for 64-bit systems that's why it should install to libdir=${prefix}/lib/${deb_host_multiarch}.

To me this should be fine now then as it works for you and the settings are read from the newly introduced folder structure. This issue will close automatically with the next commit.

[Vascom]

I built for 64-bit. And I look at other .pc files in my system - it has lib64 in .pc files.
So it is important.

Can you use some variable to set lib on 32-bit builds and lib64 on 64-bit builds?

[Nightwalker-87]

I'm not really willing to currently, because the library is still coded 32-bit, even if you build for 64-bit, as the st-link code is not written for 64-bit (this is also not planned in the foreseeable future). This is likely the reason why lib is not changed to lib64.