Fix CI: Upgrade Python, Conan, ConanPackageTools #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickpdemarco
changed the title
…and format matrix.json
|
Note that the two failing checks are both from appveyor. I have disabled those webhooks in our settings and intend to remove them altogether when this PR is merged. |
nickpdemarco
commented
Jun 9, 2022
| @@ -53,7 +56,8 @@ jobs: | |||
| python.exe --version | |||
| cmake --version | |||
| python.exe -m pip install --upgrade pip | |||
| pip.exe install conan_package_tools==0.37.0 | |||
| pip.exe install markupsafe==2.0.1 | |||
There was a problem hiding this comment.
See conan-io/conan#10611. I could not find a more appropriate workaround than this. Conan will fail if this dependency is not available.
| "os": "macos-10.15" | ||
| }, | ||
| { |
There was a problem hiding this comment.
We should consider to add VS 2022.
There was a problem hiding this comment.
I tried. Conan died with a non obvious error. I think adding that will have to be a separate task.
FelixPetriconi
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous CI cleanup. We can now format matrix.json for readability. A simple python script will flatten it before GH actions sees it. Otherwise, just straightforward tooling dependency updates.
Note: I tried to upgrade our windows targets from (windows-2016, windows-2019) to (windows-2019, windows-2022). Conan errored out early in the latter. But this should be on our radar - windows-2016 is deprecated on GH actions and will fail periodically to remind us of this fact.