Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(non-default) Executors and make_ready_future #85

Closed
drussel opened this issue Sep 5, 2017 · 3 comments
Closed

(non-default) Executors and make_ready_future #85

drussel opened this issue Sep 5, 2017 · 3 comments
Milestone

Comments

@drussel
Copy link

drussel commented Sep 5, 2017

make_ready_future uses the default executor implicitly, which doesn't matter for the future itself, but does for continuations that don't explicitly specify the executor. It seems like providing an executor argument to make_ready_future would make the API more consistent.

Currently, if you have one or more custom executors, you have to be always sure to pass them when calling .then if you use make_ready_future somewhere (and can't consistently have the continuation use the same executor as the previous).

@fosterbrereton
Copy link
Member

fosterbrereton commented Sep 5, 2017

Do the comments in issue #65 help out here at all?

@drussel
Copy link
Author

drussel commented Sep 5, 2017

Thanks. #65 suggests my understanding is correct, but doesn't address the problem I see (with having to be careful to avoid having the default executor sneak in unexpectedly from make_ready_future).

@FelixPetriconi
Copy link
Member

Make the executor an argument to the make_ functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants