-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review typing of CSS values #48
Comments
At the moment, numbers are not supported in most properties. This is because initially we didn't want to allow people to set a unitless number, and have it being converted to It seems that we've changed our minds about this, @colmtuite can you confirm, that now we do want to support unitless numbers? (with the exception of @hadihallak maybe its worth doing this together when you implement the functionality? |
Since we dont rely on I've got it to work by changing the types to this:
But will hold off until we can decide what to do |
Done in #206 |
For example,
gap
can't be a number.It may be worth referring to this https://github.com/system-ui/theme-ui/blob/f5dd5b3ee601909a52ceb14cbd5fdd1857364ef1/packages/css/src/types.ts#L14-L22
The text was updated successfully, but these errors were encountered: