Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Error Handling #63

Closed
rickychilcott opened this issue Oct 9, 2020 · 3 comments · Fixed by #97
Closed

Better Error Handling #63

rickychilcott opened this issue Oct 9, 2020 · 3 comments · Fixed by #97

Comments

@rickychilcott
Copy link
Contributor

Feature Request

Is your feature request related to a problem?

While developing some examples, I've passed in some bad parameters to a partial or there have been issues in my partials that causes futurism to never resolve the partial. As such, cable ready never sends back a valid partial.

Describe the solution you'd like

While in development mode, I'd like to see an error that replaces my placeholder ideally with a stacktrace or at least something that tells me an error has occurred and to check the logs. The logs could indicate the an error has occured.

@rickychilcott
Copy link
Contributor Author

Example log lines from this morning:

10:17:53 web.1     | Futurism::Channel is transmitting the subscription confirmation
10:17:53 web.1     | Futurism::Channel is streaming from Futurism::Channel
10:17:53 web.1     | Futurism::Channel#receive({"signed_params"=>["BAh7BzoMcGFydGlhbEkiEGhvbWUvcGFyZW50BjoGRVQ6C2xvY2Fsc3sGOgtsZXZlbHNpBw==--a527e60ae4ec7ec5661fd4988d55c7fd2de970a4", "BAh7BzoMcGFydGlhbEkiEGhvbWUvcGFyZW50BjoGRVQ6C2xvY2Fsc3sGOgtsZXZlbHNpCg==--0f1635831073906729c0b3317993274c6896314c", "BAh7BzoMcGFydGlhbEkiEGhvbWUvcGFyZW50BjoGRVQ6C2xvY2Fsc3sGOgtsZXZlbHNpDA==--93d0b5bcab3cc626f00632de40fe82ce89d6c7cb"], "sgids"=>[nil, nil, nil]})
10:17:53 web.1     |   Rendered home/_parent.erb (Duration: 0.6ms | Allocations: 755)
10:17:53 web.1     | Could not execute command from ({"command"=>"message", "identifier"=>"{\"channel\":\"Futurism::Channel\"}", "data"=>"{\"signed_params\":[\"BAh7BzoMcGFydGlhbEkiEGhvbWUvcGFyZW50BjoGRVQ6C2xvY2Fsc3sGOgtsZXZlbHNpBw==--a527e60ae4ec7ec5661fd4988d55c7fd2de970a4\",\"BAh7BzoMcGFydGlhbEkiEGhvbWUvcGFyZW50BjoGRVQ6C2xvY2Fsc3sGOgtsZXZlbHNpCg==--0f1635831073906729c0b3317993274c6896314c\",\"BAh7BzoMcGFydGlhbEkiEGhvbWUvcGFyZW50BjoGRVQ6C2xvY2Fsc3sGOgtsZXZlbHNpDA==--93d0b5bcab3cc626f00632de40fe82ce89d6c7cb\"],\"sgids\":[null,null,null]}"}) [ActionView::Template::Error - No route matches {}]: /Users/rickychilcott/github/futurism-auth-spike/.bundle/ruby/2.6.0/gems/actionpack-6.0.3.3/lib/action_dispatch/journey/formatter.rb:57:in `generate' | /Users/rickychilcott/github/futurism-auth-spike/.bundle/ruby/2.6.0/gems/actionpack-6.0.3.3/lib/action_dispatch/routing/route_set.rb:738:in `generate' | /Users/rickychilcott/github/futurism-auth-spike/.bundle/ruby/2.6.0/gems/actionpack-6.0.3.3/lib/action_dispatch/routing/route_set.rb:769:in `generate' | /Users/rickychilcott/github/futurism-auth-spike/.bundle/ruby/2.6.0/gems/actionpack-6.0.3.3/lib/action_dispatch/routing/route_set.rb:816:in `url_for' | /Users/rickychilcott/github/futurism-auth-spike/.bundle/ruby/2.6.0/gems/actionpack-6.0.3.3/lib/action_dispatch/routing/url_for.rb:180:in `full_url_for'

UI stays like this:
Screen Shot 2020-10-10 at 10 19 49 AM

@julianrubisch
Copy link
Contributor

Exactly! We do have (or had?) similar issues in StimulusReflex - the error messages being too general. Maybe it makes sense to join forces here.

@julianrubisch
Copy link
Contributor

With v3.4 logging in StimulusReflex really looks awesome, should we copy some of that over?

@rickychilcott rickychilcott mentioned this issue May 4, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants