Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a static list of GitHub usernames for the RMS supporters who linked to a non-GitHub site. #58

Open
kakafarm opened this issue Apr 2, 2021 · 3 comments

Comments

@kakafarm
Copy link

kakafarm commented Apr 2, 2021

The RMS support letter does not currently support multiple addresses, so I had to choose my GitLab account (https://github.com/yuvallangerontheroad/rms-support-letter.github.io/blob/d91e98aa23ae0b43316f0c1eafb21d0b865a33c3/_data/signed/yuvallanger.yaml#L2), but on GitHub I use this account (https://github.com/yuvallangerontheroad/), and also https://github.com/yuvallanger/.

Could you add these accounts for me as a static list of GitHub usernames, as well for others in the future who wish to add themselves but do not have a github account displayed in the RMS support letter?

Thank you!

@kakafarm kakafarm changed the title Add a static list of GitHub usernames for those the RMS supporters who linked to a non-GitHub site. Add a static list of GitHub usernames for the RMS supporters who linked to a non-GitHub site. Apr 2, 2021
@sticks-stuff
Copy link
Owner

This can likely be accomplished by scraping the contributors of the repo viat the API (provided they added their signature via a GitHub PR) and then using that to fill in the gaps of any missing usernames. I'll look into it

@kakafarm
Copy link
Author

kakafarm commented Apr 2, 2021

This can likely be accomplished by scraping the contributors of the repo viat the API (provided they added their signature via a GitHub PR) and then using that to fill in the gaps of any missing usernames. I'll look into it

Using the API would not suffice as, for example, my https://github.com/yuvallanger/ account did not submit anything to the RMS support repository.

@sticks-stuff
Copy link
Owner

This might be too much of an edge case to solve, I’m open to suggestions or PRs however

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants