fix: output for tool command to also contain error output #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickeepaul
force-pushed
the
fix/output-for-tool-command
branch
from
2883e6e to
dd9bb5b
Compare
stickeeoliver
approved these changes
Jan 3, 2023
stickeepaul
added a commit
that referenced
this pull request
Jan 3, 2023
* chore: PHP CS Fixer should check test files too. (#23) * chore: PHP CS Fixer should check test files too. * style: PHP CS Fixer Co-authored-by: stickeeoliver <[email protected]> * fix: output for tool command to also contain error output (#22) Co-authored-by: Oliver Earl <[email protected]> Co-authored-by: stickeeoliver <[email protected]>
stickeepaul
pushed a commit
that referenced
this pull request
Mar 16, 2023
## [2.0.6](v2.0.5...v2.0.6) (2023-03-16) ### Bug Fixes * output for tool command to also contain error output ([#22](#22)) ([ef9585d](ef9585d))
|
🎉 This PR is included in version 2.0.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP CS Fixer doesn't always output something afterwards (for some reason) so this changes the test for the fix command to ensure it contains expected output (that is always there).
To do this I've had to change the output for a ToolCommand to also output the "error output" - which PHP CS Fixer uses to display verbose output.