Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if running download outside expected dir #13

Open
DavidFair opened this issue Mar 17, 2023 · 1 comment
Open

Warn if running download outside expected dir #13

DavidFair opened this issue Mar 17, 2023 · 1 comment

Comments

@DavidFair
Copy link
Contributor

(More of a nit / user improvement)
Currently sciml-bench works on the assumption a user is already in the git repo when running a download.

In this case the machine rebooted, then I re-ran the download which ended up in the wrong directory.
A simple check that sciml_bench exists in the current working dir, with a warning to nudge people that you expect them to be in the source/git directory would help.

@samueljackson92
Copy link
Collaborator

Hi David, the datasets should be downloaded to dataset_root_dir in the config.yml. This is by default in the user home directory ~/scml_bench/datasets. For me, if I cd to another directory and run a download it still puts it in the correct place?

Perhaps can you provide more info as I cannot reproduce the issue you're seeing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants