From a72f981370c3f566fc1becf024f3178da041547a Mon Sep 17 00:00:00 2001
From: steviez <steven@anza.xyz>
Date: Fri, 30 Aug 2024 06:28:00 +0900
Subject: [PATCH] Remove counters from sigverify functions (#2785)

These counters should be removed for several reasons:
- Counters in general are bad (multiple atomics for a single value)
- The counters are at debug level, so effectively unused
- The reported values can be determined from SigVerifierStats

The only thing lost is whether verification was done by cpu/gpu/disabled
verifier. But, most validators are not running gpu's, so ripping this
out now and it can be re-added more properly if more validators shift to
using gpu's.
---
 perf/src/sigverify.rs | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/perf/src/sigverify.rs b/perf/src/sigverify.rs
index 0d29bfe571b81b..e10675270471ea 100644
--- a/perf/src/sigverify.rs
+++ b/perf/src/sigverify.rs
@@ -11,7 +11,6 @@ use {
         recycler::Recycler,
     },
     rayon::{prelude::*, ThreadPool},
-    solana_metrics::inc_new_counter_debug,
     solana_rayon_threadlimit::get_thread_count,
     solana_sdk::{
         hash::Hash,
@@ -531,7 +530,6 @@ pub fn ed25519_verify_cpu(batches: &mut [PacketBatch], reject_non_vote: bool, pa
                 }
             });
     });
-    inc_new_counter_debug!("ed25519_verify_cpu", packet_count);
 }
 
 pub fn ed25519_verify_disabled(batches: &mut [PacketBatch]) {
@@ -542,7 +540,6 @@ pub fn ed25519_verify_disabled(batches: &mut [PacketBatch]) {
             .par_iter_mut()
             .for_each(|p| p.meta_mut().set_discard(false))
     });
-    inc_new_counter_debug!("ed25519_verify_disabled", packet_count);
 }
 
 pub fn copy_return_values<I, T>(sig_lens: I, out: &PinnedVec<u8>, rvs: &mut [Vec<u8>])
@@ -672,7 +669,6 @@ pub fn ed25519_verify(
     trace!("done verify");
     copy_return_values(sig_lens, &out, &mut rvs);
     mark_disabled(batches, &rvs);
-    inc_new_counter_debug!("ed25519_verify_gpu", valid_packet_count);
 }
 
 #[cfg(test)]