Exercise 11, shorter solution by avoiding duplicated code

[mnummeli]

It is possible to write an inner function to handle the otherwise duplicate code in promise handlers, i.e.

'use strict';

function all(promise1, promise2) {
    return new Promise((fulfill, reject) => {
    let counter = 0;
    let out = [];
    function update(val, loc) {
        out[loc] = val;
        counter++;
        if(counter >= 2) {
        fulfill(out);
        }
    }
    promise1.then((val) => update(val, 0));
    promise2.then((val) => update(val, 1));
    });
}

all(getPromise1(), getPromise2()).then(console.log);

[ayhtrak]

Seriously??

The whole point of the solution was to make clear the synchronous behavior of Promise.all
Abstracting the multiple call by wrapping in a custom function doesn't serve the purpose

[ohcibi]

@ayhtrak in what way is the official solution making clear that Promise.all is synchronous?? The current solution as well as this proposed solutions both do two sequentially calls to .then; the only difference is that this solution has the function passed to .then declared before both calls..

If you really want to show the synchronous behavior, the solution should go like

promise1.then(() => {
   // ...
   return promise2
}).then(...)