Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support promise.catch in exercise Reject a promise #138

Open
TylerYang opened this issue Dec 3, 2017 · 1 comment
Open

Support promise.catch in exercise Reject a promise #138

TylerYang opened this issue Dec 3, 2017 · 1 comment

Comments

@TylerYang
Copy link
Contributor

TylerYang commented Dec 3, 2017 •
edited
Loading

In reject a promise exercise, we didn't support promise.then while catching the rejection. Check this link.

catch and then(null, handleError) are basically the same thing, and instead of doing promise.then(null, handleError), an experienced user would just use promise.catch(handleError). Like issue #125.

I would like to send a pr if you think supporting promise.catch in reject a promise is reasonable. Looking forward to your opinion.
@TimothyGu
Copy link
Collaborator

Sure, a patch would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TimothyGu @TylerYang