Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple promises solution fails verification - 'you did not call then from function all' #130

Open
natcreates opened this issue Sep 7, 2017 · 2 comments

Comments

@natcreates
Copy link

My solution was getting the expected output but not passing verification because 'You did not call then from function all'. As I was, and to make sure I wasn't going mad, I double-checked by copying and pasting the official solution. The same error is shown.

@codingdojo-dkitzmiller
Copy link

I have this same issue for both resolve and reject. Code below is for resolve. The expected values are passing but the other tests of the "Promise Constructor", "fulfill" method and "then" method are not being recognized. Can you give me a clue ?

'use strict';

import {Promise} from "es6-promise"

function onResolved(d: string) {
console.log(${d});
}

function onRejected(d: string) {
console.log(${d});
}

let promise = new Promise((fulfill: Function, reject: Function) => {

setTimeout(() => {
    fulfill("FULFILLED!");
}, 300);

}).then(onResolved)
.catch(onRejected);

@meeple142
Copy link

for @codingdojo-dkitzmiller at least, my guess is that it has something to do with the fact that you are using typescript not es6.
For example, function onRejected(d: string) is typescript, specifically the d: script part.

Hope this helps :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants