Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't report exception when location not found - Maxmind driver #183

Closed
veronikaValentii opened this issue Oct 25, 2024 · 1 comment · Fixed by #184
Closed

Don't report exception when location not found - Maxmind driver #183

veronikaValentii opened this issue Oct 25, 2024 · 1 comment · Fixed by #184
Labels

Comments

@veronikaValentii
Copy link

when we use driver maxmind and ip not found in location file - we have large error log with stack trace (screen 1)

Знімок екрана 2024-10-25 о 10 06 48

it works in this way, because when we call rescue function, not pass parameter report on false (screen 2)

Знімок екрана 2024-10-25 о 10 13 37

but when we use other drivers and location not found by ip - we have result false and no error log, because parameter report passed (screen 3)

Знімок екрана 2024-10-25 о 10 02 34

can you handle not find location for maxmind driver on the same way as other drivers and not show error log?

Thanks for any help!

@stevebauman stevebauman changed the title show error log when location not found - Maxmind driver Don't report exception when location not found - Maxmind driver Oct 27, 2024
@stevebauman
Copy link
Owner

Fixed in v7.3.3. Thanks for the report! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants