Support for gulp-sourcemaps

[leepowelldev]

... would be great.
https://github.com/floridoo/gulp-sourcemaps

[sylvainbaronnet]

+1

[leepowelldev]

New version of stylus now supports source maps (http://learnboost.github.io/stylus/docs/sourcemaps.html), however this isn't really a viable solution if you pipe stylus output to any post-processors.

[sylvainbaronnet]

Maybe it works with post processor if you use "inline" option ?

[stephenlacy]

It seems that it will work with inline set, any test builds so far?

[leepowelldev]

Would it still work if you then piped the output through something like gulp-pxtorem?
Wouldn't that then mess up the line numbers references of the source maps due to actually modifying the resulting CSS?

[heikki]

@leepowellcouk Every plugin between sourcemaps.init and sourcemaps.write need to support sourcemaps. Plugins with gulp sourcemaps support are listed here:

https://github.com/floridoo/gulp-sourcemaps/wiki/Plugins-with-gulp-sourcemaps-support

[leepowelldev]

IMO thats the preferable way to go - the more plugins with support for gulp-sourcemaps the easier it is to pipe them together. Each plugin trying to support sourcemaps independently is just leading to more problems. It's great that Stylus can now support them, but in workflow environments that utilise gulp or grunt then we need more flexibility.

[jescalan]

Will be working on getting this feature into accord shortly -- issue open here: jescalan/accord#52

[leepowelldev]

👍

[stephenlacy]

@Jenius sourcemaps can work now with this setup: #73 (comment)

[redders6600]

This doesn't seem to work if using the nib plugin with gulp-stylus, I get following:

Potentially unhandled rejection [1] Error: 
  "node_modules/nib/lib/nib/vendor.styl" is not in the SourceMap.

This is possibly an issue with the node nib library (tj/nib/#265)

[jescalan]

Good news, we have a PR open to add source map support to accord. It is a breaking change, but once this has been merged and shipped I'll submit a PR to upgrade this library cleanly.

jescalan/accord#56

[stephenlacy]

👍

[yocontra]

Is this in yet?

[jescalan]

Just published a new version of accord with full support for sourcemaps yesterday, so we can implement this whenever!

[stephenlacy]

@Jenius Nice, lets do it!

[jescalan]

I'll try to get a PR in before next Monday if I can manage 😁

[efolio]

\o/ Thrilled to see that it should soon be available!
Can't wait to see :D

[jescalan]

Good news guys, I just finished implementing this and it works gloriously. Both inline and external sourcemaps are looking great. I'd expect this feature to ship out today. Whoo! 🎉 🎊

[stephenlacy]

👍