Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auto-detecting .graphqlconfig without useLanguageServer #7

Open
stephen opened this issue Jan 4, 2018 · 3 comments
Open

Support auto-detecting .graphqlconfig without useLanguageServer #7

stephen opened this issue Jan 4, 2018 · 3 comments

Comments

@stephen
Copy link
Owner

stephen commented Jan 4, 2018

Ideally, we do not need the useLanguageServer flag, or at least enable it by default. This might require either running graphql-config locally to find configuration files, or making the language server more resilient to missing configuration.

@lostplan
Copy link
Contributor

lostplan commented Jan 24, 2018

This could be handled by the activationEvents in package.json.

E.g.:

{
  ...
  "activationEvents": ["workspaceContains:**/.graphqlconfig"],
  ...
}

@lostplan
Copy link
Contributor

This will cause the extension to be eagerly loaded in projects that contain .graphqlconfig, but does get around the need to add a dependency on graphql-config.

What do you think?

@divyenduz
Copy link

I think this one can be closed now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants