Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to merge PR due to commit signature #1718

Closed
miguelnietoa opened this issue Dec 22, 2022 · 4 comments
Closed

Unable to merge PR due to commit signature #1718

miguelnietoa opened this issue Dec 22, 2022 · 4 comments

Comments

@miguelnietoa
Copy link

Hi there 👋🏻

GitHub has a rule that requires commits to be signed.

Seems like this PR contains commits that are not signed, and therefore I am unable to merge it. Although it has Signed-off-by: StepSecurity Bot <[email protected]> in the commit description. 🤔

Not sure why GitHub doesn't recognize it as a verified commit.

PR: kommitters/stellar_sdk#264

⬇️ Notice the last text ❌ Merging is blocked

image

@miguelnietoa
Copy link
Author

I will merge the PR however it would be good to investigate why what I said is happening!

I look forward to any updates or interest around this. 👍🏻

@varunsh-coder
Copy link
Member

Thanks, @miguelnietoa, for creating the issue! I think this is happening because the commits are not signed using GPG, SSH, or S/MIME. https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

We will investigate how to do this for the bot and get back.

CC: @boahc077

@miguelnietoa
Copy link
Author

Yes @varunsh-coder, that's why! 👍🏻 Thanks a lot

@varunsh-coder
Copy link
Member

This issue is resolved. Here is an example. Please re-open if you see an issue with the fix.
dhurley/github-actions-playground#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants