-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidySCE
Functionality to see and access the altExp slot
#81
Comments
You are very right. I though about it many times. We can add it to the tidyomics challenges. Are you aware of the page? |
tidySCE
Functionality to see and access the altExp slot
I was not before but I am now :) |
Great, it is here https://github.com/orgs/tidyomics/projects/1/views/1 Let's see if someone wants to commit to that. If you like the challenge and want to be part of our almost-ready-to-submit paper on tidyomics, feel free to propose yourself! |
Sure, I'd be happy to contribute. |
Amazing. I think two aspects are surely the header of tibble representation and the join_feature. maybe some care should be given when there are assays with repairs named how the front end would look like. as user what you feel is missing? what tidy operations would you like to do with the alternative Experiment? |
I think for starters there needs to be at least a mention in the print method that the altExp is not empty. As it is currently in |
Ok let's start from adding altexp:assay_name in the header. How about if there are multiple altexp? we could do altexp[[1]]:assay_name? do altexp have names usually? |
Yes, the
|
Cool. Of course, the philosophy of our interface is being modular rather than recursive (such as SCE inside and SCE). great, so if header and join_features are the only additions, I think it is pretty straightforward. When we choose assay to join the feature from, we look both in regural and alternative experiments. After this maybe we can think about, multiple PCA, UMAP etc.. |
@Biomiha please add your authorship details here https://docs.google.com/spreadsheets/d/19XqhN3xAMekCJ-esAolzoWT6fttruSEermjIsrOFcoo/edit?usp=sharing |
I suppose I should actually contribute first, no :)? |
Yes! as soon you manage to do a PR feel free to add yourself. |
Hi Stefano, Quick question if I may? I am new to pillar and have found the print method and the utilities files in the repo but can't seem to find where Thanks, |
Did you try to look for "setup" in all .R files? I have to say that I am not an expert of Were you able to orient yourself in the print method, where I modify the header of the "tibble"? |
I've looked a bit yes but again I am new to modifying printing methods for tibbles so could very well be looking in the wrong place. |
The fact that I could add "feature" means that you can change that :) |
Please look at tidySingleCellExperiment/R/print_method.R Line 34 in 797cf25
|
Yes, that was the one I was looking at. I think I have been able to figure it out. Should submit a PR in the next couple of days. |
Hi all,
I am really liking your package, it has made many operations infinitely easier. We tend to prefer the
tidySingleCellExperiment
to Seurat, however, the one thing we have noticed is that there is no functionality to access thealtExp
slot, where our CITE-seq data are stored. In the standardSingleCellExperiment
print method thealtExpNames
are listed at the bottom, whereas this is completely hidden in the tibble abstraction. Could this possibly be added?Many thanks in advance.
The text was updated successfully, but these errors were encountered: