Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/244 #245

Closed
wants to merge 7 commits into from
Closed

Feature/244 #245

wants to merge 7 commits into from

Conversation

twellspring
Copy link
Contributor

@twellspring twellspring commented Jun 26, 2019

Fixes #244

Should be merged after 147

@twellspring twellspring requested a review from a team June 26, 2019 22:01
Copy link
Contributor

@kidbrax kidbrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would hold off on this. Or pull out the Dockerfile-dev changes. I need to rethink this. As is, these changes wouldn't update Gemfile.lock on the host if changes are made to the Gemfile

@twellspring
Copy link
Contributor Author

Not having a good Dockerfile-dev makes it hard for a new person to get started with cfn_nag. Once 147 is committed, the only changes that this should make are the Readme.md and the Dockerfile-dev.

@jesseadams
Copy link

This branch needs rebased and tests should pass.

@twellspring
Copy link
Contributor Author

Easier to start over then try to merge this.

@ghost ghost deleted the feature/244 branch February 26, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile-dev failing, documentation needs updating
3 participants