Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/KAD-3245 #532

Merged
merged 3 commits into from
Sep 18, 2024
Merged

bugfix/KAD-3245 #532

merged 3 commits into from
Sep 18, 2024

Conversation

gilbert-hernandez
Copy link
Contributor

@gilbert-hernandez gilbert-hernandez commented Aug 20, 2024 •
edited
Loading

🎫 #[Jira Ticket]
https://stellarwp.atlassian.net/browse/KAD-3245
...

Issue Info

  • Were you able to reproduce the issue?
  • Is the issue from the ticket solved? (If not, why?)

Checklist

  • I have performed a self-review.
  • No unrelated files are modified.
  • No debugging statements exist (Ex: console.log, error_log).
  • There are no warnings or notices in the wordpress error log.
  • Passes all tests (linting, acceptance, & unit)

Block specific checklist (where relevant)

  • Tested with an existing instance of this block .
  • Tested creating a new instance of this block.
  • Tested with Dynamic content & Elements.

Are there dependent changes in another repository?

  • No.
  • Yes. Please provide the link to the PR.

@gilbert-hernandez
Copy link
Contributor Author

I consolidated the code to use a new private function set_vertical_align

@oakesjosh oakesjosh merged commit e45cc4a into master Sep 18, 2024
20 checks passed
@oakesjosh oakesjosh deleted the bugfix/KAD-3245 branch September 18, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oakesjosh oakesjosh oakesjosh approved these changes

@mark-c-woodard mark-c-woodard Awaiting requested review from mark-c-woodard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilbert-hernandez @oakesjosh