Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more ledger details to getLedger/getLatestLedger #79

Open
leighmcculloch opened this issue Feb 24, 2024 · 1 comment
Open

Add more ledger details to getLedger/getLatestLedger #79

leighmcculloch opened this issue Feb 24, 2024 · 1 comment

Comments

@leighmcculloch
Copy link
Member

The getLatestLedger endpoint should return all information about the ledger, such as the ledger header, and any other details the rpc knows about the ledger.

Currently it only reports the following:

❯ http POST :8000/soroban/rpc jsonrpc=2.0 id=0 method=getLatestLedger
HTTP/1.1 200 OK
Accept-Post: application/json
Connection: keep-alive
Content-Length: 148
Content-Type: application/json
Date: Sat, 24 Feb 2024 00:03:04 GMT
Server: nginx/1.18.0 (Ubuntu)
Vary: Origin
Vary: Origin

{
    "id": "0",
    "jsonrpc": "2.0",
    "result": {
        "id": "171f5f42a7375f17a10b9633c063ec35291a6253e9f309d13d31a55933f537ed",
        "protocolVersion": 20,
        "sequence": 283919
    }
}

Related to:

@aditya1702
Copy link
Contributor

getLatestLedger should include the same info that we decide for getLedgers implementation. Both tickets can be combined together. cc @Shaptic @2opremio

@aditya1702 aditya1702 removed their assignment Nov 5, 2024
@2opremio 2opremio moved this from To Do to In Progress in Platform Scrum Dec 3, 2024
@aditya1702 aditya1702 moved this from In Progress to Needs Review in Platform Scrum Dec 12, 2024
@aditya1702 aditya1702 removed their assignment Dec 19, 2024
@aditya1702 aditya1702 moved this from Needs Review to Backlog in Platform Scrum Dec 19, 2024
@aditya1702 aditya1702 removed this from the platform sprint 54 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

5 participants