Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated getLedgerEntry endpoint #258

Closed
Tracked by #5433
Shaptic opened this issue Aug 1, 2024 · 0 comments · Fixed by #276
Closed
Tracked by #5433

Remove the deprecated getLedgerEntry endpoint #258

Shaptic opened this issue Aug 1, 2024 · 0 comments · Fixed by #276
Assignees
@aditya1702
Labels
breaking-change Breaking change tag Protocol 22 rpc-sdk-scrum
Milestone
platform sprint 50

Comments

@Shaptic
Copy link
Contributor

Shaptic commented Aug 1, 2024

What problem does your feature solve?

This endpoint is deprecated and it's undocumented and superseded by the much more powerful getLedgerEntries. We should remove it as part of Protocol 22's breaking changes.

What would you like to see?

No more getLedgerEntry.

What alternatives are there?

Keeping it for no reason or at least merging the implementation with getLedgerEntries.
@Shaptic Shaptic added the breaking-change Breaking change tag label Aug 1, 2024
@Shaptic Shaptic moved this from Backlog to To Do in Platform Scrum Aug 1, 2024
@Shaptic Shaptic added this to the platform sprint 50 milestone Aug 1, 2024
@aditya1702 aditya1702 self-assigned this Aug 6, 2024
@Shaptic Shaptic mentioned this issue Aug 13, 2024
Open
19 tasks
@Shaptic Shaptic moved this from To Do to Blocked in Platform Scrum Aug 13, 2024
@Shaptic Shaptic moved this from Blocked to To Do in Platform Scrum Aug 13, 2024
@Shaptic Shaptic mentioned this issue Aug 19, 2024
Closed
10 tasks
@aditya1702 aditya1702 mentioned this issue Aug 27, 2024
Merged
@aditya1702 aditya1702 moved this from Needs Review to Done in Platform Scrum Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aditya1702 aditya1702

Labels
breaking-change Breaking change tag Protocol 22 rpc-sdk-scrum
Projects
Platform Scrum
Status: Done
Milestone
platform sprint 50
Development

Successfully merging a pull request may close this issue.

Remove deprecated getLedgerEntry endpoint aditya1702/soroban-rpc
2 participants
@Shaptic @aditya1702