Skip to content

Enable Golangci-lint #2

Enable Golangci-lint

Enable Golangci-lint #2

Triggered via pull request June 18, 2024 21:39
Status Failure
Total duration 3m 6s
Artifacts

golang.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 5 warnings
golangci: cmd/soroban-rpc/internal/network/requestdurationlimiter.go#L51
unexported-return: exported func MakeHTTPRequestDurationLimiter returns unexported type *network.httpRequestDurationLimiter, which can be annoying to use (revive)
golangci: cmd/soroban-rpc/internal/network/requestdurationlimiter.go#L211
unexported-return: exported func MakeJrpcRequestDurationLimiter returns unexported type *network.rpcRequestDurationLimiter, which can be annoying to use (revive)
golangci: cmd/soroban-rpc/internal/daemon/daemon.go#L70
type assertion must be checked (forcetypeassert)
golangci: cmd/soroban-rpc/internal/config/parse.go#L26
type assertion must be checked (forcetypeassert)
golangci
issues found
golangci
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b, actions/setup-go@268d8c0ca0432bb2cf416faae41297df9d262d7f. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
golangci
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
golangci
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
golangci
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
golangci
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/