From 937aa81944c905f0de367b1d68ece45652381f37 Mon Sep 17 00:00:00 2001 From: Tyler van der Hoeven Date: Thu, 3 Aug 2023 11:34:10 -0400 Subject: [PATCH 1/2] Delete devcontainer.json --- .devcontainer/devcontainer.json | 18 ------------------ 1 file changed, 18 deletions(-) delete mode 100644 .devcontainer/devcontainer.json diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json deleted file mode 100644 index de6bd51a2..000000000 --- a/.devcontainer/devcontainer.json +++ /dev/null @@ -1,18 +0,0 @@ -{ - "name": "Node.js", - "image": "mcr.microsoft.com/vscode/devcontainers/javascript-node:18", - "features": { - "ghcr.io/devcontainers/features/git:1": {}, - "ghcr.io/devcontainers/features/github-cli:1": {}, - "ghcr.io/devcontainers/features/node:1": {} - }, - "extensions": [ - "unifiedjs.vscode-mdx", - "dbaeumer.vscode-eslint", - "streetsidesoftware.code-spell-checker" - ], - "forwardPorts": [3000], - "postCreateCommand": "yarn install && yarn run build", - "waitFor": "postCreateCommand", - "postAttachCommand": "yarn start" -} From 2b3a48cd87c5e0d410139f9c738fca5afa6625de Mon Sep 17 00:00:00 2001 From: Tyler van der Hoeven Date: Thu, 3 Aug 2023 11:35:21 -0400 Subject: [PATCH 2/2] check yarn build as well in the GH Action --- .github/workflows/main.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 8ff5d4419..05d7ad819 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -25,8 +25,10 @@ jobs: - name: Install App Dependencies run: yarn --prefer-offline - - name: Format MDX with Prettier + - name: Check MDX run: yarn check:mdx - # - name: Lint with ESLint - # run: yarn lint:fix + - name: Build app + run: yarn build + +