Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI docs should describe where the config files are and how to overwrite #815

Closed
janewang opened this issue Jul 22, 2024 · 5 comments
Closed

Comments

@janewang
Copy link
Contributor

What problem does your feature solve?

It appears that some developers are unaware of where to find and use the config files

What would you like to see?

A page about the CLI describing the config files and how can ovewrite

@leighmcculloch
Copy link
Member

To a large degree the config files are an implementation detail of the cli.

If their contents become documented they become an api.

There's benefits to discussing they exist but unclear to me if there's benefits right now to discussing their internals.

@janewang
Copy link
Contributor Author

janewang commented Aug 1, 2024

Hmm, I see. I think there are use cases where users may want to overwrite the content to associate a seedphrase derived from keypair of their choosing

@willemneal
Copy link
Member

willemneal commented Aug 1, 2024

I think it's worth mentioning where you can find the files. But I agree that we might want to change the config data representation in the future and could migrate users data for them and their code will break if they had ways of trying to look up info by reading the files directly. Projects like Loam, however, will have to use them because we don't want to pull in the CLI crate to access the data. But for us we are very aware of the changes and will also hide the details from end users.

@leighmcculloch
Copy link
Member

I think there are use cases where users may want to overwrite the content to associate a seedphrase derived from keypair of their choosing

I think that's something we could add a command for if it's a workflow that needs supporting.

Devs will also naturally dig into config files and fiddle with them as they need to, without us promoting that it is a stable API, so not documenting it is not prohibiting someone doing that with the config file if they need.

@janewang
Copy link
Contributor Author

janewang commented Aug 2, 2024

Hmm okay, I could close this but I think it's worth mentioning where the config files are.

@janewang janewang closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants