Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Advanced Config' Button and Menu #59

Open
JakeUrban opened this issue Nov 25, 2020 · 2 comments
Open

Add 'Advanced Config' Button and Menu #59

JakeUrban opened this issue Nov 25, 2020 · 2 comments
Labels
enhancement New feature or request v1.3

Comments

@JakeUrban
Copy link
Contributor

Developers will want to tweek the way the demo wallet operates in order to test all edge cases on their anchor.

For example, Settle asked us to add a on_change_callback field to the existing demo client today. The demo wallet should also be able to do that. Note that this includes updating the URL so the config is completely sharable.

@JakeUrban JakeUrban added the enhancement New feature or request label Nov 25, 2020
@shanzzam
Copy link
Contributor

shanzzam commented Mar 5, 2021

@JakeUrban Is this still a feature request in the revamped Demo Wallet? If so, where would this be configured @lydiat

@JakeUrban
Copy link
Contributor Author

I think the plan was to implement this in V2. The idea is that there are optional features provided in the SEPs, and the anchor using our demo wallet will likely want to test the implementation of those optional features by explicitly enabling them.

We could take the approach of defaulting to using this optional features, but then the anchor wouldn't be able to test flows where those optional features are not requested/enabled.

For example, anchors can optionally create claimable balances for users requesting a SEP-24 deposit, but only does so if the wallet uses the claimable_balance_supported: "true" flag in the deposit request. Our current demo wallet passes this parameter, but this means anchors implementing this feature cannot test for the case where the wallet doesn't send the parameter.

If we had an optional config menu, the user could toggle whether or not this claimable_balance_supported flag was used, enabling testing of both flows.

@shanzzam shanzzam added the v1.3 label Apr 27, 2021
@JakeUrban JakeUrban reopened this May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.3
Projects
None yet
Development

No branches or pull requests

3 participants
@shanzzam @JakeUrban and others