Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate old-style survey responses after v20 upgrade #4164

Closed
marta-lokhova opened this issue Jan 26, 2024 · 5 comments
Closed

Deprecate old-style survey responses after v20 upgrade #4164

marta-lokhova opened this issue Jan 26, 2024 · 5 comments
Assignees

Comments

@marta-lokhova
Copy link
Contributor

After the upgrade, it won't be possible for nodes to generate v0 survey response (since all nodes must be on overlay version 31), so we should deprecate it.

@bboston7
Copy link
Contributor

Closing because #4275 deprecated the V0 and V1 surveys. #4332 tracks the removal of these older survey versions.

@marta-lokhova
Copy link
Contributor Author

#4332 looks like a dupe of this issue to me: this issue originally tracked code removal and cleanup on older versions of survey.

@marta-lokhova
Copy link
Contributor Author

I don't mind using #4332, just seems like we already had an issue tracking old-style survey deprecation (the issue needed to be updated to include v1 though).

@bboston7
Copy link
Contributor

Ah, I guess I saw deprecation and removal as two separate actions. These are now deprecated (they emit warnings upon use and the docs no longer refer to them), but still need to be removed.

@bboston7
Copy link
Contributor

Next time I'll use the same ticket for both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@bboston7 @marta-lokhova and others