Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: rename TxSetFrame to TxSetXDRFrame #4017

Closed
dmkozh opened this issue Nov 8, 2023 · 0 comments · Fixed by #4057
Closed

Cleanup: rename TxSetFrame to TxSetXDRFrame #4017

dmkozh opened this issue Nov 8, 2023 · 0 comments · Fixed by #4057
Assignees
@dmkozh
Labels
enhancement

Comments

@dmkozh
Copy link
Contributor

dmkozh commented Nov 8, 2023

This is a followup refactor for #3977: we can now rename TxSetFrame for clarity to something like ``TxSetXDRFrame(as it only wraps around the XDR without interpretation). Also we might move some factory functions out ofTxSetFrame` (it's a bit weird that `makeFromTransactions` also returns `ApplicableTxSetFrame` while being a static function of `TxSetFrame`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmkozh dmkozh

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

No-op refactor of TxSetFrame. dmkozh/stellar-core
1 participant
@dmkozh