From 5ae83d0036098b5d9a5fb15a907056a5f06ade36 Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Thu, 10 Aug 2023 16:09:22 -0700 Subject: [PATCH 01/22] use latest core version in e2e tests --- .github/workflows/e2e.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 9123e1ca1..9b75b1f4b 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -22,7 +22,7 @@ jobs: # core git ref should be latest commit for stable soroban functionality # the core bin can either be compiled in-line here as part of ci, - SYSTEM_TEST_CORE_GIT_REF: https://github.com/stellar/stellar-core.git#875f47e247cefc25c8a4b3982ee65610e6a620e3 + SYSTEM_TEST_CORE_GIT_REF: https://github.com/stellar/stellar-core.git#35170ec6c543ecc492e0ade8b32671cebd4df985 SYSTEM_TEST_CORE_COMPILE_CONFIGURE_FLAGS: "--disable-tests --enable-next-protocol-version-unsafe-for-production" # or can use option to pull a pre-compiled image instead # SYSTEM_TEST_CORE_IMAGE: @@ -36,7 +36,7 @@ jobs: # system test will build quickstart image internally to use for running the service stack # configured in standalone network mode(core, rpc) - SYSTEM_TEST_QUICKSTART_GIT_REF: https://github.com/stellar/quickstart.git#df8303380d5869272852ddb45c39abfeb7d4c938 + SYSTEM_TEST_QUICKSTART_GIT_REF: https://github.com/stellar/quickstart.git#c8826f5d8f80d54e819d1aca310cec3005f89175 # triggers system test to log out details from quickstart's logs and test steps SYSTEM_TEST_VERBOSE_OUTPUT: "true" From 4d480866323d09f59fc9f58495f4a956dd27d4eb Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Fri, 11 Aug 2023 17:35:06 -0700 Subject: [PATCH 02/22] updated system test git ref --- .github/workflows/e2e.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 9b75b1f4b..7c2963973 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -14,7 +14,7 @@ jobs: runs-on: ubuntu-latest-4-cores env: # the gh tag of system-test repo version to run - SYSTEM_TEST_GIT_REF: "a27c4941564dea24518d26111ecb5a29e5e8ff79" + SYSTEM_TEST_GIT_REF: "b4e1d0e96092be325e4593feecb434eeb3c371f8" # the soroban tools source code to compile and run from system test # refers to checked out source of current git hub ref context From 556c17376aa68e200fac763428aea739d41de4d5 Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Fri, 11 Aug 2023 17:49:23 -0700 Subject: [PATCH 03/22] include bump on the soroban client git ref --- .github/workflows/e2e.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 7c2963973..43f1fae51 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -32,7 +32,7 @@ jobs: SYSTEM_TEST_RUST_TOOLCHAIN_VERSION: stable # sets the version of soroban-js-client used by tests - SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION: "0.9.2" + SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION: "https://github.com/stellar/js-soroban-client#331637a19040680a5fb203a03bd5e7b12299c80c" # system test will build quickstart image internally to use for running the service stack # configured in standalone network mode(core, rpc) From c7f9259a92a292b59ba747edee396b55a1e70ba2 Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Sun, 13 Aug 2023 12:36:42 -0700 Subject: [PATCH 04/22] changed gh ref for js-soroban-client on e2e.yml --- .github/workflows/e2e.yml | 29 ++++++++++++++++++++++++++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 43f1fae51..17e43e404 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -31,8 +31,15 @@ jobs: # test runtime environment, tests invoke rustc/cargo SYSTEM_TEST_RUST_TOOLCHAIN_VERSION: stable - # sets the version of soroban-js-client used by tests - SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION: "https://github.com/stellar/js-soroban-client#331637a19040680a5fb203a03bd5e7b12299c80c" + # set the version of js-soroban-client to use, need to choose one of either + # resolution options, using npm release or a gh ref: + # + # option #1, set the version of soroban-js-client based on a npm release version + SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION: 0.9.2 + # option #2, set the version of soroban-js-client used as a ref to a gh repo + # if this value is present it takes precedence over any SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION + SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO: stellar/js-soroban-client + SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REF: upgrade-base-xdr # system test will build quickstart image internally to use for running the service stack # configured in standalone network mode(core, rpc) @@ -46,17 +53,33 @@ jobs: SYSTEM_TEST_SOROBAN_EXAMPLES_GIT_REPO: "https://github.com/stellar/soroban-examples.git" steps: - uses: actions/checkout@v3 + name: checkout system-test with: repository: stellar/system-test ref: ${{ env.SYSTEM_TEST_GIT_REF }} path: system-test - uses: actions/checkout@v3 + name: checkout soroban-tools with: path: soroban-tools + - if: ${{ env.SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO }} + name: checkout js-soroban-client + run: | + rm -rf $GITHUB_WORKSPACE/system-test/js-soroban-client; + uses: actions/checkout@v3 + with: + repository: ${{ env.SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO }} + ref: ${{ SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REF }} + path: $GITHUB_WORKSPACE/system-test/js-soroban-client - uses: stellar/actions/rust-cache@main - name: Build system test with component versions run: | cd $GITHUB_WORKSPACE/system-test; \ + if [ -z "$SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO" ]; then \ + JS_SOROBAN_CLIENT_REF="$SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION" \ + else \ + JS_SOROBAN_CLIENT_REF=file:/home/tester/js-soroban-client \ + fi \ make \ CORE_GIT_REF=$SYSTEM_TEST_CORE_GIT_REF \ CORE_COMPILE_CONFIGURE_FLAGS="$SYSTEM_TEST_CORE_COMPILE_CONFIGURE_FLAGS" \ @@ -65,7 +88,7 @@ jobs: SOROBAN_CLI_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF \ RUST_TOOLCHAIN_VERSION=$SYSTEM_TEST_RUST_TOOLCHAIN_VERSION \ QUICKSTART_GIT_REF=$SYSTEM_TEST_QUICKSTART_GIT_REF \ - JS_SOROBAN_CLIENT_NPM_VERSION=$SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION \ + JS_SOROBAN_CLIENT_NPM_VERSION=$JS_SOROBAN_CLIENT_REF \ build - name: Run system test scenarios run: | From 8e6404230e4c805d176af7fb71c2b22ced6b7dc1 Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Sun, 13 Aug 2023 14:02:54 -0700 Subject: [PATCH 05/22] reference new version of system test that has soroban-client local file build fix --- .github/workflows/e2e.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 17e43e404..df56e5360 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -14,7 +14,7 @@ jobs: runs-on: ubuntu-latest-4-cores env: # the gh tag of system-test repo version to run - SYSTEM_TEST_GIT_REF: "b4e1d0e96092be325e4593feecb434eeb3c371f8" + SYSTEM_TEST_GIT_REF: refs/pull/74/head # the soroban tools source code to compile and run from system test # refers to checked out source of current git hub ref context From aff662402fc76201c20abe3a255f6095cda5dd38 Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Sun, 13 Aug 2023 14:06:00 -0700 Subject: [PATCH 06/22] fix gha run/uses in step def --- .github/workflows/e2e.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index df56e5360..e5e38ec3a 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -63,9 +63,10 @@ jobs: with: path: soroban-tools - if: ${{ env.SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO }} - name: checkout js-soroban-client + name: prepare local js-soroban-client run: | rm -rf $GITHUB_WORKSPACE/system-test/js-soroban-client; + - if: ${{ env.SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO }} uses: actions/checkout@v3 with: repository: ${{ env.SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO }} From 434e3e2179e514c56d30fe54db86120d9d905a2c Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Sun, 13 Aug 2023 14:09:15 -0700 Subject: [PATCH 07/22] fixed gha parsing error on env variable --- .github/workflows/e2e.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index e5e38ec3a..13f20533c 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -70,8 +70,8 @@ jobs: uses: actions/checkout@v3 with: repository: ${{ env.SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO }} - ref: ${{ SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REF }} - path: $GITHUB_WORKSPACE/system-test/js-soroban-client + ref: ${{ env.SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REF }} + path: system-test/js-soroban-client - uses: stellar/actions/rust-cache@main - name: Build system test with component versions run: | From 29e5b73028008b8681bbf66f9db98a05f54c489e Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Sun, 13 Aug 2023 14:14:13 -0700 Subject: [PATCH 08/22] use gha run multiline syntax --- .github/workflows/e2e.yml | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 13f20533c..fe18d9280 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -74,22 +74,22 @@ jobs: path: system-test/js-soroban-client - uses: stellar/actions/rust-cache@main - name: Build system test with component versions - run: | - cd $GITHUB_WORKSPACE/system-test; \ - if [ -z "$SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO" ]; then \ - JS_SOROBAN_CLIENT_REF="$SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION" \ - else \ - JS_SOROBAN_CLIENT_REF=file:/home/tester/js-soroban-client \ - fi \ - make \ - CORE_GIT_REF=$SYSTEM_TEST_CORE_GIT_REF \ - CORE_COMPILE_CONFIGURE_FLAGS="$SYSTEM_TEST_CORE_COMPILE_CONFIGURE_FLAGS" \ - CORE_IMAGE=$SYSTEM_TEST_CORE_IMAGE \ - SOROBAN_RPC_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF \ - SOROBAN_CLI_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF \ - RUST_TOOLCHAIN_VERSION=$SYSTEM_TEST_RUST_TOOLCHAIN_VERSION \ - QUICKSTART_GIT_REF=$SYSTEM_TEST_QUICKSTART_GIT_REF \ - JS_SOROBAN_CLIENT_NPM_VERSION=$JS_SOROBAN_CLIENT_REF \ + run: > + cd $GITHUB_WORKSPACE/system-test; + if [ -z "$SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO" ]; then + JS_SOROBAN_CLIENT_REF="$SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION" + else + JS_SOROBAN_CLIENT_REF=file:/home/tester/js-soroban-client + fi + make + CORE_GIT_REF=$SYSTEM_TEST_CORE_GIT_REF + CORE_COMPILE_CONFIGURE_FLAGS="$SYSTEM_TEST_CORE_COMPILE_CONFIGURE_FLAGS" + CORE_IMAGE=$SYSTEM_TEST_CORE_IMAGE + SOROBAN_RPC_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF + SOROBAN_CLI_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF + RUST_TOOLCHAIN_VERSION=$SYSTEM_TEST_RUST_TOOLCHAIN_VERSION + QUICKSTART_GIT_REF=$SYSTEM_TEST_QUICKSTART_GIT_REF + JS_SOROBAN_CLIENT_NPM_VERSION=$JS_SOROBAN_CLIENT_REF build - name: Run system test scenarios run: | From b69c2fbfdb2a9346ba3cde8654235992ea50cc7e Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Sun, 13 Aug 2023 14:24:30 -0700 Subject: [PATCH 09/22] fixing gha line continuation on if statement --- .github/workflows/e2e.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index fe18d9280..0179db026 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -74,12 +74,12 @@ jobs: path: system-test/js-soroban-client - uses: stellar/actions/rust-cache@main - name: Build system test with component versions - run: > + run: | cd $GITHUB_WORKSPACE/system-test; - if [ -z "$SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO" ]; then - JS_SOROBAN_CLIENT_REF="$SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION" - else - JS_SOROBAN_CLIENT_REF=file:/home/tester/js-soroban-client + if [ -z "$SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO" ]; then \ + JS_SOROBAN_CLIENT_REF="$SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION" \ + else \ + JS_SOROBAN_CLIENT_REF=file:/home/tester/js-soroban-client \ fi make CORE_GIT_REF=$SYSTEM_TEST_CORE_GIT_REF @@ -90,7 +90,7 @@ jobs: RUST_TOOLCHAIN_VERSION=$SYSTEM_TEST_RUST_TOOLCHAIN_VERSION QUICKSTART_GIT_REF=$SYSTEM_TEST_QUICKSTART_GIT_REF JS_SOROBAN_CLIENT_NPM_VERSION=$JS_SOROBAN_CLIENT_REF - build + build; - name: Run system test scenarios run: | docker run --rm -t --name e2e_test stellar/system-test:dev \ From 262fdfbae97a3957cd07e1f19276356e5ba7cd87 Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Sun, 13 Aug 2023 14:27:25 -0700 Subject: [PATCH 10/22] include line continuation on make command still --- .github/workflows/e2e.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 0179db026..a423bc543 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -81,15 +81,15 @@ jobs: else \ JS_SOROBAN_CLIENT_REF=file:/home/tester/js-soroban-client \ fi - make - CORE_GIT_REF=$SYSTEM_TEST_CORE_GIT_REF - CORE_COMPILE_CONFIGURE_FLAGS="$SYSTEM_TEST_CORE_COMPILE_CONFIGURE_FLAGS" - CORE_IMAGE=$SYSTEM_TEST_CORE_IMAGE - SOROBAN_RPC_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF - SOROBAN_CLI_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF - RUST_TOOLCHAIN_VERSION=$SYSTEM_TEST_RUST_TOOLCHAIN_VERSION - QUICKSTART_GIT_REF=$SYSTEM_TEST_QUICKSTART_GIT_REF - JS_SOROBAN_CLIENT_NPM_VERSION=$JS_SOROBAN_CLIENT_REF + make \ + CORE_GIT_REF=$SYSTEM_TEST_CORE_GIT_REF \ + CORE_COMPILE_CONFIGURE_FLAGS="$SYSTEM_TEST_CORE_COMPILE_CONFIGURE_FLAGS" \ + CORE_IMAGE=$SYSTEM_TEST_CORE_IMAGE \ + SOROBAN_RPC_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF \ + SOROBAN_CLI_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF \ + RUST_TOOLCHAIN_VERSION=$SYSTEM_TEST_RUST_TOOLCHAIN_VERSION \ + QUICKSTART_GIT_REF=$SYSTEM_TEST_QUICKSTART_GIT_REF \ + JS_SOROBAN_CLIENT_NPM_VERSION=$JS_SOROBAN_CLIENT_REF \ build; - name: Run system test scenarios run: | From 09952ab83568c5790641d4948729ca1f9fa447dc Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Sun, 13 Aug 2023 14:35:17 -0700 Subject: [PATCH 11/22] fix multiline command pipe syntax on gha step --- .github/workflows/e2e.yml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index a423bc543..e273c7611 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -75,22 +75,22 @@ jobs: - uses: stellar/actions/rust-cache@main - name: Build system test with component versions run: | - cd $GITHUB_WORKSPACE/system-test; + cd $GITHUB_WORKSPACE/system-test if [ -z "$SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO" ]; then \ - JS_SOROBAN_CLIENT_REF="$SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION" \ + JS_SOROBAN_CLIENT_REF="$SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION" \ else \ - JS_SOROBAN_CLIENT_REF=file:/home/tester/js-soroban-client \ + JS_SOROBAN_CLIENT_REF=file:/home/tester/js-soroban-client \ fi make \ - CORE_GIT_REF=$SYSTEM_TEST_CORE_GIT_REF \ - CORE_COMPILE_CONFIGURE_FLAGS="$SYSTEM_TEST_CORE_COMPILE_CONFIGURE_FLAGS" \ - CORE_IMAGE=$SYSTEM_TEST_CORE_IMAGE \ - SOROBAN_RPC_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF \ - SOROBAN_CLI_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF \ - RUST_TOOLCHAIN_VERSION=$SYSTEM_TEST_RUST_TOOLCHAIN_VERSION \ - QUICKSTART_GIT_REF=$SYSTEM_TEST_QUICKSTART_GIT_REF \ - JS_SOROBAN_CLIENT_NPM_VERSION=$JS_SOROBAN_CLIENT_REF \ - build; + CORE_GIT_REF=$SYSTEM_TEST_CORE_GIT_REF \ + CORE_COMPILE_CONFIGURE_FLAGS="$SYSTEM_TEST_CORE_COMPILE_CONFIGURE_FLAGS" \ + CORE_IMAGE=$SYSTEM_TEST_CORE_IMAGE \ + SOROBAN_RPC_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF \ + SOROBAN_CLI_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF \ + RUST_TOOLCHAIN_VERSION=$SYSTEM_TEST_RUST_TOOLCHAIN_VERSION \ + QUICKSTART_GIT_REF=$SYSTEM_TEST_QUICKSTART_GIT_REF \ + JS_SOROBAN_CLIENT_NPM_VERSION=$JS_SOROBAN_CLIENT_REF \ + build - name: Run system test scenarios run: | docker run --rm -t --name e2e_test stellar/system-test:dev \ From a44f159b2cac604a2aa6a5cb559bc6439a2f602d Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Sun, 13 Aug 2023 14:54:10 -0700 Subject: [PATCH 12/22] fix multiline if statement to have line ending semicolons --- .github/workflows/e2e.yml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index e273c7611..f8bf14d51 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -77,20 +77,20 @@ jobs: run: | cd $GITHUB_WORKSPACE/system-test if [ -z "$SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO" ]; then \ - JS_SOROBAN_CLIENT_REF="$SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION" \ + JS_SOROBAN_CLIENT_REF="$SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION"; \ else \ - JS_SOROBAN_CLIENT_REF=file:/home/tester/js-soroban-client \ + JS_SOROBAN_CLIENT_REF="file:/home/tester/js-soroban-client"; \ fi make \ - CORE_GIT_REF=$SYSTEM_TEST_CORE_GIT_REF \ - CORE_COMPILE_CONFIGURE_FLAGS="$SYSTEM_TEST_CORE_COMPILE_CONFIGURE_FLAGS" \ - CORE_IMAGE=$SYSTEM_TEST_CORE_IMAGE \ - SOROBAN_RPC_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF \ - SOROBAN_CLI_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF \ - RUST_TOOLCHAIN_VERSION=$SYSTEM_TEST_RUST_TOOLCHAIN_VERSION \ - QUICKSTART_GIT_REF=$SYSTEM_TEST_QUICKSTART_GIT_REF \ - JS_SOROBAN_CLIENT_NPM_VERSION=$JS_SOROBAN_CLIENT_REF \ - build + CORE_GIT_REF=$SYSTEM_TEST_CORE_GIT_REF \ + CORE_COMPILE_CONFIGURE_FLAGS="$SYSTEM_TEST_CORE_COMPILE_CONFIGURE_FLAGS" \ + CORE_IMAGE=$SYSTEM_TEST_CORE_IMAGE \ + SOROBAN_RPC_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF \ + SOROBAN_CLI_GIT_REF=$SYSTEM_TEST_SOROBAN_TOOLS_REF \ + RUST_TOOLCHAIN_VERSION=$SYSTEM_TEST_RUST_TOOLCHAIN_VERSION \ + QUICKSTART_GIT_REF=$SYSTEM_TEST_QUICKSTART_GIT_REF \ + JS_SOROBAN_CLIENT_NPM_VERSION=$JS_SOROBAN_CLIENT_REF \ + build - name: Run system test scenarios run: | docker run --rm -t --name e2e_test stellar/system-test:dev \ From 7741db47cb65f866e86f0f63df4492ec73ce3a39 Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Sun, 20 Aug 2023 15:43:35 -0700 Subject: [PATCH 13/22] use a version of soroban-examples that has latest sdk ref for latest core --- .github/workflows/e2e.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index f8bf14d51..8bd7c2147 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -35,11 +35,11 @@ jobs: # resolution options, using npm release or a gh ref: # # option #1, set the version of soroban-js-client based on a npm release version - SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION: 0.9.2 + SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION: # option #2, set the version of soroban-js-client used as a ref to a gh repo # if this value is present it takes precedence over any SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO: stellar/js-soroban-client - SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REF: upgrade-base-xdr + SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REF: refs/pull/126/head # system test will build quickstart image internally to use for running the service stack # configured in standalone network mode(core, rpc) @@ -49,8 +49,8 @@ jobs: SYSTEM_TEST_VERBOSE_OUTPUT: "true" # the soroban test cases will compile various contracts from the examples repo - SYSTEM_TEST_SOROBAN_EXAMPLES_GIT_HASH: "main" - SYSTEM_TEST_SOROBAN_EXAMPLES_GIT_REPO: "https://github.com/stellar/soroban-examples.git" + SYSTEM_TEST_SOROBAN_EXAMPLES_GIT_HASH: "e2e_version_bump" + SYSTEM_TEST_SOROBAN_EXAMPLES_GIT_REPO: "https://github.com/sreuland/soroban-examples.git" steps: - uses: actions/checkout@v3 name: checkout system-test From 6b8c08be2a5f53eab88f7323c3b713b72c769267 Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Sun, 20 Aug 2023 17:24:00 -0700 Subject: [PATCH 14/22] include soroban examples repo url in test run command --- .github/workflows/e2e.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 8bd7c2147..c98173ece 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -96,4 +96,5 @@ jobs: docker run --rm -t --name e2e_test stellar/system-test:dev \ --VerboseOutput $SYSTEM_TEST_VERBOSE_OUTPUT \ --TestFilter "${{ matrix.scenario-filter }}" \ - --SorobanExamplesGitHash $SYSTEM_TEST_SOROBAN_EXAMPLES_GIT_HASH + --SorobanExamplesGitHash $SYSTEM_TEST_SOROBAN_EXAMPLES_GIT_HASH \ + --SorobanExamplesRepoURL $SYSTEM_TEST_SOROBAN_EXAMPLES_GIT_REPO From 3f8824281d132694298897d2890b8dcd280e4cb6 Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Mon, 21 Aug 2023 11:49:09 -0700 Subject: [PATCH 15/22] use soroban-examples:testnet tag for latest contract source --- .github/workflows/e2e.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index c98173ece..09a2a1f3f 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -49,8 +49,8 @@ jobs: SYSTEM_TEST_VERBOSE_OUTPUT: "true" # the soroban test cases will compile various contracts from the examples repo - SYSTEM_TEST_SOROBAN_EXAMPLES_GIT_HASH: "e2e_version_bump" - SYSTEM_TEST_SOROBAN_EXAMPLES_GIT_REPO: "https://github.com/sreuland/soroban-examples.git" + SYSTEM_TEST_SOROBAN_EXAMPLES_GIT_HASH: "testnet" + SYSTEM_TEST_SOROBAN_EXAMPLES_GIT_REPO: "https://github.com/stellar/soroban-examples.git" steps: - uses: actions/checkout@v3 name: checkout system-test From 074d24ad0e1897115ede9e398ed228271dabd293 Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Mon, 21 Aug 2023 15:55:54 -0700 Subject: [PATCH 16/22] update the system-test repo reference --- .github/workflows/e2e.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 09a2a1f3f..271b8fc39 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -14,7 +14,7 @@ jobs: runs-on: ubuntu-latest-4-cores env: # the gh tag of system-test repo version to run - SYSTEM_TEST_GIT_REF: refs/pull/74/head + SYSTEM_TEST_GIT_REF: 1e39ad9fe1e0852ba286e7668aee1f899dd0b96d # the soroban tools source code to compile and run from system test # refers to checked out source of current git hub ref context @@ -35,11 +35,11 @@ jobs: # resolution options, using npm release or a gh ref: # # option #1, set the version of soroban-js-client based on a npm release version - SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION: + SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION: 0.11.0 # option #2, set the version of soroban-js-client used as a ref to a gh repo # if this value is present it takes precedence over any SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION - SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO: stellar/js-soroban-client - SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REF: refs/pull/126/head + # SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO: stellar/js-soroban-client + # SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REF: refs/pull/126/head # system test will build quickstart image internally to use for running the service stack # configured in standalone network mode(core, rpc) From e6afa3031d4f1c9b84fcd57d50e3fa18480cc1e0 Mon Sep 17 00:00:00 2001 From: Willem Wyndham Date: Tue, 22 Aug 2023 10:25:31 -0400 Subject: [PATCH 17/22] fix(CLI): update to new RPC for simulation response --- cmd/soroban-cli/src/rpc/mod.rs | 37 +++++++++++++++++------ cmd/soroban-cli/src/rpc/transaction.rs | 42 ++++++++++++++------------ 2 files changed, 51 insertions(+), 28 deletions(-) diff --git a/cmd/soroban-cli/src/rpc/mod.rs b/cmd/soroban-cli/src/rpc/mod.rs index c0fdc6520..75dc717f8 100644 --- a/cmd/soroban-cli/src/rpc/mod.rs +++ b/cmd/soroban-cli/src/rpc/mod.rs @@ -95,6 +95,8 @@ pub enum Error { Spec(#[from] soroban_spec::read::FromWasmError), #[error(transparent)] SpecBase64(#[from] soroban_spec::read::ParseSpecBase64Error), + #[error("Fee was too large {0}")] + LargeFee(u64), } #[derive(serde::Deserialize, serde::Serialize, Debug)] @@ -204,25 +206,42 @@ pub struct SimulateHostFunctionResult { #[derive(serde::Deserialize, serde::Serialize, Debug)] pub struct SimulateTransactionResponse { - #[serde(skip_serializing_if = "Option::is_none", default)] - pub error: Option, - #[serde(rename = "transactionData")] - pub transaction_data: String, - #[serde(deserialize_with = "deserialize_default_from_null")] - pub events: Vec, #[serde( rename = "minResourceFee", deserialize_with = "deserialize_number_from_string" )] - pub min_resource_fee: u32, + pub min_resource_fee: u64, + pub cost: Cost, #[serde(skip_serializing_if = "Vec::is_empty", default)] pub results: Vec, - pub cost: Cost, + #[serde(rename = "transactionData")] + pub transaction_data: String, + #[serde(deserialize_with = "deserialize_default_from_null")] + pub events: Vec, + #[serde( + skip_serializing_if = "Option::is_none", + default, + rename = "restorePreamble" + )] + pub restore_preamble: Option, #[serde( rename = "latestLedger", deserialize_with = "deserialize_number_from_string" )] - pub latest_ledger: u32, + pub latest_ledger: u64, + #[serde(skip_serializing_if = "Option::is_none", default)] + pub error: Option, +} + +#[derive(serde::Deserialize, serde::Serialize, Debug)] +pub struct RestorePreamble { + #[serde(rename = "transactionData")] + pub transaction_data: String, + #[serde( + rename = "minResourceFee", + deserialize_with = "deserialize_number_from_string" + )] + pub min_resource_fee: u64, } #[derive(serde::Deserialize, serde::Serialize, Debug)] diff --git a/cmd/soroban-cli/src/rpc/transaction.rs b/cmd/soroban-cli/src/rpc/transaction.rs index 341451452..eef9cb322 100644 --- a/cmd/soroban-cli/src/rpc/transaction.rs +++ b/cmd/soroban-cli/src/rpc/transaction.rs @@ -82,10 +82,11 @@ pub fn assemble( // update the fees of the actual transaction to meet the minimum resource fees. let classic_transaction_fees = crate::fee::Args::default().fee; // Pad the fees up by 15% for a bit of wiggle room. - tx.fee = (tx - .fee - .max(classic_transaction_fees + simulation.min_resource_fee) - * 115) + tx.fee = (tx.fee.max( + classic_transaction_fees + + u32::try_from(simulation.min_resource_fee) + .map_err(|_| Error::LargeFee(simulation.min_resource_fee))?, + ) * 115) / 100; tx.operations = vec![op].try_into()?; @@ -288,19 +289,20 @@ mod tests { }; SimulateTransactionResponse { - error: None, - transaction_data: transaction_data().to_xdr_base64().unwrap(), - events: Vec::default(), min_resource_fee: 115, - results: vec![SimulateHostFunctionResult { - auth: vec![fn_auth.to_xdr_base64().unwrap()], - xdr: ScVal::U32(0).to_xdr_base64().unwrap(), - }], cost: Cost { cpu_insns: "0".to_string(), mem_bytes: "0".to_string(), }, + results: vec![SimulateHostFunctionResult { + auth: vec![fn_auth.to_xdr_base64().unwrap()], + xdr: ScVal::U32(0).to_xdr_base64().unwrap(), + }], + transaction_data: transaction_data().to_xdr_base64().unwrap(), + events: Vec::default(), + restore_preamble: None, latest_ledger: 3, + error: None, } } @@ -408,16 +410,17 @@ mod tests { let result = assemble( &txn, &SimulateTransactionResponse { - error: None, - transaction_data: transaction_data().to_xdr_base64().unwrap(), - events: Vec::default(), min_resource_fee: 115, - results: vec![], cost: Cost { cpu_insns: "0".to_string(), mem_bytes: "0".to_string(), }, + results: vec![], + transaction_data: transaction_data().to_xdr_base64().unwrap(), + events: Vec::default(), + restore_preamble: None, latest_ledger: 3, + error: None, }, None, ); @@ -435,16 +438,17 @@ mod tests { let result = assemble( &txn, &SimulateTransactionResponse { - error: None, - transaction_data: transaction_data().to_xdr_base64().unwrap(), - events: Vec::default(), min_resource_fee: 115, - results: vec![], cost: Cost { cpu_insns: "0".to_string(), mem_bytes: "0".to_string(), }, + results: vec![], + transaction_data: transaction_data().to_xdr_base64().unwrap(), + events: Vec::default(), + restore_preamble: None, latest_ledger: 3, + error: None, }, None, ); From 50ae29929795af2036f294ed53e42d1be5faa28c Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Tue, 22 Aug 2023 17:20:50 -0700 Subject: [PATCH 18/22] updated js-soroban-client to latest with xdr --- .github/workflows/e2e.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 271b8fc39..f3b075a07 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -35,11 +35,11 @@ jobs: # resolution options, using npm release or a gh ref: # # option #1, set the version of soroban-js-client based on a npm release version - SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION: 0.11.0 + SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION: # option #2, set the version of soroban-js-client used as a ref to a gh repo # if this value is present it takes precedence over any SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION - # SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO: stellar/js-soroban-client - # SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REF: refs/pull/126/head + SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO: stellar/js-soroban-client + SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REF: refs/pull/121/head # system test will build quickstart image internally to use for running the service stack # configured in standalone network mode(core, rpc) From f8c94aa43b91b35d8565de23ff9d466e86d8ae1f Mon Sep 17 00:00:00 2001 From: Willem Wyndham Date: Tue, 22 Aug 2023 15:44:04 -0400 Subject: [PATCH 19/22] fix: skip serializing events if there are none --- cmd/soroban-cli/src/rpc/mod.rs | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/cmd/soroban-cli/src/rpc/mod.rs b/cmd/soroban-cli/src/rpc/mod.rs index 75dc717f8..1f9106913 100644 --- a/cmd/soroban-cli/src/rpc/mod.rs +++ b/cmd/soroban-cli/src/rpc/mod.rs @@ -216,7 +216,11 @@ pub struct SimulateTransactionResponse { pub results: Vec, #[serde(rename = "transactionData")] pub transaction_data: String, - #[serde(deserialize_with = "deserialize_default_from_null")] + #[serde( + deserialize_with = "deserialize_default_from_null", + skip_serializing_if = "Vec::is_empty", + default + )] pub events: Vec, #[serde( skip_serializing_if = "Option::is_none", @@ -855,6 +859,19 @@ pub fn parse_cursor(c: &str) -> Result<(u64, i32), Error> { mod tests { use super::*; + #[test] + fn simulation_transaction_response_parsing() { + let s = r#"{ + "minResourceFee": "100000000", + "cost": { "cpuInsns": "1000", "memBytes": "1000" }, + "transactionData": "", + "latestLedger": "1234" + }"#; + + let resp: SimulateTransactionResponse = serde_json::from_str(s).unwrap(); + assert_eq!(resp.min_resource_fee, 100_000_000); + } + #[test] fn test_rpc_url_default_ports() { // Default ports are added. From 622a04a2ea83c0da1e34cc4b58bd97a8d4282346 Mon Sep 17 00:00:00 2001 From: Willem Wyndham Date: Thu, 24 Aug 2023 10:07:15 -0400 Subject: [PATCH 20/22] fix: make all omitable fields use a default; fix Cost type to use u64s --- cmd/soroban-cli/src/rpc/mod.rs | 28 +++++++++++++++++------- cmd/soroban-cli/src/rpc/transaction.rs | 30 +++++--------------------- 2 files changed, 25 insertions(+), 33 deletions(-) diff --git a/cmd/soroban-cli/src/rpc/mod.rs b/cmd/soroban-cli/src/rpc/mod.rs index 1f9106913..3920f786f 100644 --- a/cmd/soroban-cli/src/rpc/mod.rs +++ b/cmd/soroban-cli/src/rpc/mod.rs @@ -183,18 +183,18 @@ pub struct GetLatestLedgerResponse { pub sequence: u32, } -#[derive(serde::Deserialize, serde::Serialize, Debug)] +#[derive(serde::Deserialize, serde::Serialize, Debug, Default)] pub struct Cost { #[serde( rename = "cpuInsns", deserialize_with = "deserialize_number_from_string" )] - pub cpu_insns: String, + pub cpu_insns: u64, #[serde( rename = "memBytes", deserialize_with = "deserialize_number_from_string" )] - pub mem_bytes: String, + pub mem_bytes: u64, } #[derive(serde::Deserialize, serde::Serialize, Debug)] @@ -204,17 +204,19 @@ pub struct SimulateHostFunctionResult { pub xdr: String, } -#[derive(serde::Deserialize, serde::Serialize, Debug)] +#[derive(serde::Deserialize, serde::Serialize, Debug, Default)] pub struct SimulateTransactionResponse { #[serde( rename = "minResourceFee", - deserialize_with = "deserialize_number_from_string" + deserialize_with = "deserialize_number_from_string", + default )] pub min_resource_fee: u64, + #[serde(default)] pub cost: Cost, #[serde(skip_serializing_if = "Vec::is_empty", default)] pub results: Vec, - #[serde(rename = "transactionData")] + #[serde(rename = "transactionData", default)] pub transaction_data: String, #[serde( deserialize_with = "deserialize_default_from_null", @@ -223,9 +225,9 @@ pub struct SimulateTransactionResponse { )] pub events: Vec, #[serde( + rename = "restorePreamble", skip_serializing_if = "Option::is_none", - default, - rename = "restorePreamble" + default )] pub restore_preamble: Option, #[serde( @@ -872,6 +874,16 @@ mod tests { assert_eq!(resp.min_resource_fee, 100_000_000); } + #[test] + fn simulation_transaction_response_parsing_mostly_empty() { + let s = r#"{ + "latestLedger": "1234" + }"#; + + let resp: SimulateTransactionResponse = serde_json::from_str(s).unwrap(); + assert_eq!(resp.latest_ledger, 1_234); + } + #[test] fn test_rpc_url_default_ports() { // Default ports are added. diff --git a/cmd/soroban-cli/src/rpc/transaction.rs b/cmd/soroban-cli/src/rpc/transaction.rs index eef9cb322..46c2c2ab8 100644 --- a/cmd/soroban-cli/src/rpc/transaction.rs +++ b/cmd/soroban-cli/src/rpc/transaction.rs @@ -238,7 +238,7 @@ pub fn sign_soroban_authorization_entry( mod tests { use super::*; - use super::super::{Cost, SimulateHostFunctionResult}; + use super::super::SimulateHostFunctionResult; use soroban_env_host::xdr::{ self, AccountId, ChangeTrustAsset, ChangeTrustOp, ExtensionPoint, Hash, HostFunction, InvokeContractArgs, InvokeHostFunctionOp, LedgerFootprint, Memo, MuxedAccount, Operation, @@ -290,19 +290,13 @@ mod tests { SimulateTransactionResponse { min_resource_fee: 115, - cost: Cost { - cpu_insns: "0".to_string(), - mem_bytes: "0".to_string(), - }, + latest_ledger: 3, results: vec![SimulateHostFunctionResult { auth: vec![fn_auth.to_xdr_base64().unwrap()], xdr: ScVal::U32(0).to_xdr_base64().unwrap(), }], transaction_data: transaction_data().to_xdr_base64().unwrap(), - events: Vec::default(), - restore_preamble: None, - latest_ledger: 3, - error: None, + ..Default::default() } } @@ -411,16 +405,9 @@ mod tests { &txn, &SimulateTransactionResponse { min_resource_fee: 115, - cost: Cost { - cpu_insns: "0".to_string(), - mem_bytes: "0".to_string(), - }, - results: vec![], transaction_data: transaction_data().to_xdr_base64().unwrap(), - events: Vec::default(), - restore_preamble: None, latest_ledger: 3, - error: None, + ..Default::default() }, None, ); @@ -439,16 +426,9 @@ mod tests { &txn, &SimulateTransactionResponse { min_resource_fee: 115, - cost: Cost { - cpu_insns: "0".to_string(), - mem_bytes: "0".to_string(), - }, - results: vec![], transaction_data: transaction_data().to_xdr_base64().unwrap(), - events: Vec::default(), - restore_preamble: None, latest_ledger: 3, - error: None, + ..Default::default() }, None, ); From 2c24750da2de9185049d5ae11ad8522076ce0ac6 Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Tue, 29 Aug 2023 15:48:01 -0700 Subject: [PATCH 21/22] updated core git ref for preview 10 --- .github/workflows/e2e.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index f3b075a07..5ab4b682f 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -22,7 +22,7 @@ jobs: # core git ref should be latest commit for stable soroban functionality # the core bin can either be compiled in-line here as part of ci, - SYSTEM_TEST_CORE_GIT_REF: https://github.com/stellar/stellar-core.git#35170ec6c543ecc492e0ade8b32671cebd4df985 + SYSTEM_TEST_CORE_GIT_REF: https://github.com/sisuresh/stellar-core.git#431e4e324597507c9e2c2e62a1648034ba7c09b3 SYSTEM_TEST_CORE_COMPILE_CONFIGURE_FLAGS: "--disable-tests --enable-next-protocol-version-unsafe-for-production" # or can use option to pull a pre-compiled image instead # SYSTEM_TEST_CORE_IMAGE: From f8444d67760d55b296cb1d64e6fc155d9e6e7f74 Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Fri, 1 Sep 2023 12:07:37 -0700 Subject: [PATCH 22/22] updated core git and js refs --- .github/workflows/e2e.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 5ab4b682f..2bd43b1fc 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -22,7 +22,7 @@ jobs: # core git ref should be latest commit for stable soroban functionality # the core bin can either be compiled in-line here as part of ci, - SYSTEM_TEST_CORE_GIT_REF: https://github.com/sisuresh/stellar-core.git#431e4e324597507c9e2c2e62a1648034ba7c09b3 + SYSTEM_TEST_CORE_GIT_REF: https://github.com/stellar/stellar-core.git#22b9bb38416e5ce058eb9c1fadfdd414a4661833 SYSTEM_TEST_CORE_COMPILE_CONFIGURE_FLAGS: "--disable-tests --enable-next-protocol-version-unsafe-for-production" # or can use option to pull a pre-compiled image instead # SYSTEM_TEST_CORE_IMAGE: @@ -39,7 +39,7 @@ jobs: # option #2, set the version of soroban-js-client used as a ref to a gh repo # if this value is present it takes precedence over any SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO: stellar/js-soroban-client - SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REF: refs/pull/121/head + SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REF: refs/pull/132/head # system test will build quickstart image internally to use for running the service stack # configured in standalone network mode(core, rpc)