CLI: Deploy native token contract

[jonjove]

What problem does your feature solve?

The deployment path for native contracts is different from WASM contracts.

What would you like to see?

A nice interface to deploying the native token contract.

What alternatives are there?

TODO

[leighmcculloch]

I think we should replace the term native in user facing things with "builtin". Native is an implementation detail that a developer actually doesn't need to know about. What they do need to know is that the contract is built into the runtime.

I think we should avoid the term native in the CLI and make it look like a convenience function to deploy a "built in" contract. Instead of providing a --wasm file.wasm it'd be --builtin token.

We should avoid separate subcommands as that increases the top level surface area of the CLI which will make it harder to approach on first use.

[paulbellamy]

Plus-one on builtin vs native. Native is not super informative for the dev.

I'm less opposed to a separate subcommand, though. For example, for algorand ASAs, they do:

goal asset create \
  --creator <address> \
  --total 1000 \
  --unitname <unit-name> \
  --asseturl "https://path/to/my/asset/details" \
  --decimals 0 \
  -d data

Which is very clean and understandable what it is doing. It separates it out from "normal" contracts, as a special thing.

[tsachiherman]

so, on Algorand, the assets have their own set of transaction types.

[tsachiherman]

I believe that this was a mistake that we didn't catch up early.

[tsachiherman]

that is - it's ok to have a special transaction type for creating/destroying an asset. but the "regular" transfer transaction should be capable to be used for both assets and native coin ( xlm ).

[tsachiherman]

I think that for us, having a token-contract might be a bit misleading for the end-users ( compared to eth ). we do have the concept of assets - which aren't programmatic at all. this task is about creating a "virtual" asset that lives as a smart contract. I'm not sure what the best "name" for that, though. maybe smart asset in compared to non-smart assets ? ( "smart" as an indication of the smart contract ). problem is, it renders the native assets to be non-smart.

[paulbellamy]

Ok, this would be the same transaction type under-the-hood, just exposing it in a different way to the cli.

[paulbellamy]

This is blocked on @sisuresh changing how token contract deployment works.

[tsachiherman]

blocked by stellar/rs-soroban-env#446

[tsachiherman]

unblocked now.

[paulbellamy]

Now blocked by stellar/stellar-core#3547

[sisuresh]

@paulbellamy This should be unblocked now that stellar/rs-soroban-env@96d7a04 was merged.