Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban-rpc: cache the network config ledger key and provide it to the env-host during preflight #513

Closed
tsachiherman opened this issue Mar 6, 2023 · 4 comments
Closed

soroban-rpc: cache the network config ledger key and provide it to the env-host during preflight #513

tsachiherman opened this issue Mar 6, 2023 · 4 comments
Assignees
@2opremio
Labels
soroban-scrum

Comments

@tsachiherman
Copy link
Contributor

tsachiherman commented Mar 6, 2023 •
edited
Loading

What

cache the network config ledger key and provide it to the env-host during preflight

Note: We already store all ledger entries, so that part should already be done.

When we run a preflight we will need to load the NetworkConfigLedgerEntry, and pass it's value into the Host object for preflight. This will let the preflight account for the configured network limits, etc.

Epic

#519
@tsachiherman tsachiherman mentioned this issue Mar 6, 2023
Closed
@tsachiherman tsachiherman changed the title update ingestion to support network config transactions soroban-rpc: cache the network config ledger key and provide it to the env-host during preflight Mar 9, 2023
@Shaptic
Copy link
Contributor

Shaptic commented Mar 10, 2023

Shouldn't this be in the soroban-tools repo?

@tsachiherman
Copy link
Contributor Author

Shouldn't this be in the soroban-tools repo?

yes, let me move it.

@tsachiherman tsachiherman transferred this issue from stellar/go Mar 10, 2023
@tsachiherman tsachiherman mentioned this issue Mar 16, 2023
Closed
@mollykarcher mollykarcher moved this from Backlog to Next Sprint Proposal in Platform Scrum Apr 18, 2023
@2opremio 2opremio self-assigned this Apr 19, 2023
@2opremio
Copy link
Contributor

I think this is a noop (we just need to bump the stellar/go dependency to stellar/go#4851 )

@2opremio 2opremio mentioned this issue Apr 21, 2023
Merged
@2opremio
Copy link
Contributor

Closed by #608

@github-project-automation github-project-automation bot moved this from Next Sprint Proposal to Done in Platform Scrum Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2opremio 2opremio

Labels
soroban-scrum
Projects
Platform Scrum
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@paulbellamy @Shaptic @2opremio @tsachiherman