Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-cli: value overhaul update - contract deploy/install commands #479

Closed
tsachiherman opened this issue Mar 6, 2023 · 5 comments
Closed

Comments

@tsachiherman
Copy link
Contributor

What

soroban-cli: value overhaul update - contract deploy/install commands

Epic

#471

@willemneal
Copy link
Member

If I understand this right it's that deploy/install still works with the new XDR?

@tsachiherman
Copy link
Contributor Author

If I understand this right it's that deploy/install still works with the new XDR?

This ticket is to ensure that when using the soroban-cli, the deployment/install would still work against the latest core release. I suspect changes to the XDR would have resulted in parameters changes that could have broken the contract deployment/install.

@willemneal
Copy link
Member

They still pass the tests that install and deploy contracts. However, the network tests were removed from this repo.

Is it worth adding some tests to show that the install/deploy works on a standalone network?

@tsachiherman
Copy link
Contributor Author

there is a test that should be implemented in system-tests that would cover that. here, I think that manual verification would be a great starting point. ( i.e. just to make sure there is a likely chance that the automated test would work ).

@willemneal
Copy link
Member

Just manually verified it with a local standalone instance.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Platform Scrum Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants