-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
soroban-cli: value overhaul update - contract deploy/install commands #479
Comments
If I understand this right it's that deploy/install still works with the new XDR? |
This ticket is to ensure that when using the soroban-cli, the deployment/install would still work against the latest core release. I suspect changes to the XDR would have resulted in parameters changes that could have broken the contract deployment/install. |
They still pass the tests that install and deploy contracts. However, the network tests were removed from this repo. Is it worth adding some tests to show that the install/deploy works on a standalone network? |
there is a test that should be implemented in system-tests that would cover that. here, I think that manual verification would be a great starting point. ( i.e. just to make sure there is a likely chance that the automated test would work ). |
Just manually verified it with a local standalone instance. |
What
soroban-cli: value overhaul update - contract deploy/install commands
Epic
#471
The text was updated successfully, but these errors were encountered: