Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring colors to help message #1624

Closed
Ifropc opened this issue Sep 25, 2024 · 11 comments · Fixed by #1650
Closed

Bring colors to help message #1624

Ifropc opened this issue Sep 25, 2024 · 11 comments · Fixed by #1650
Assignees
Labels

Comments

@Ifropc
Copy link
Contributor

Ifropc commented Sep 25, 2024

What problem does your feature solve?

Currently our help input is black and white

What would you like to see?

It would be great to add color theme, just it's in cargo and other commands
Ref: clap-rs/clap#3234

What alternatives are there?

N/A

@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Sep 25, 2024
@ShantelPeters
Copy link

Please can I take this up @Ifropc

Copy link

onlydustapp bot commented Sep 25, 2024

Hey @ShantelPeters!
Thanks for showing interest.
We've created an application for you to contribute to Stellar CLI.
Go check it out on OnlyDust!

@martinvibes
Copy link

hello @Ifropc @leighmcculloch i am a frontend dev and blockchain developer
please can i work on this issue :) and would love to be a contributor

this issue would be easy to tackle

Copy link

onlydustapp bot commented Sep 26, 2024

Hey @martinvibes!
Thanks for showing interest.
We've created an application for you to contribute to Stellar CLI.
Go check it out on OnlyDust!

@vestor-dev
Copy link

please @Ifropc let me work on this :)
kindly assign

Copy link

onlydustapp bot commented Sep 26, 2024

Hey @dev-chinx!
Thanks for showing interest.
We've created an application for you to contribute to Stellar CLI.
Go check it out on OnlyDust!

@janewang janewang moved this from Backlog (Not Ready) to Todo (Ready for Dev) in DevX Sep 30, 2024
@Abeeujah
Copy link
Contributor

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I'm a Web and Systems Software Engineer, with experience building TUI applications in Rust, GoLang (ratatui, clap, bubbletea and termui).

How I plan on tackling this issue

  • Get the Desired color scheme to be implemented from the maintainers, preferrably included in the Xterm_256 color chart, has a AnsiColor implementation already or proceed with the current stellar brand colors.
  • Create a Custom style scheme preset using the provided color scheme by the maintainers.
  • Implement the preset styles by providing the styles attribute to the command interface.

@Kaminar-i
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

helloi would love to work on this issue
i'm a frontend developer and blockchain dev

How I plan on tackling this issue

please kindly assign and i'll get to work

@Abeeujah
Copy link
Contributor

Abeeujah commented Oct 1, 2024

Screenshot_20241001_132935
Screenshot_20241001_132951

Hi @janewang @leighmcculloch @Ifropc Please can you confirm you're satisfied with the current color theme or if there's a specified color theme you'd prefer?

@github-project-automation github-project-automation bot moved this from Todo (Ready for Dev) to Done in DevX Oct 4, 2024
@leighmcculloch
Copy link
Member

@janewang I pushed a tweak to the PR to change the colors to match the same colours that cargo uses.

Two motivations for this:

  • @Ifropc suggested colours like cargo in the original issue comment
  • Devs often will use cargo and soroban-cli side-by-side, so the fact they look the same and have the same appearance may be helpful

Alternatively, @janewang maybe there is value in getting the design team's input, and maybe we should be using "Stellar" colors?

@Ifropc
Copy link
Contributor Author

Ifropc commented Oct 4, 2024

Agree that in the future we may want to re-visit it to use "Stellar" colors ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

8 participants