Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check-dependencies script #1110

Closed
tamirms opened this issue Dec 6, 2023 · 1 comment · Fixed by #1129
Closed

Fix check-dependencies script #1110

tamirms opened this issue Dec 6, 2023 · 1 comment · Fixed by #1129
Assignees
Labels
bug Something isn't working

Comments

@tamirms
Copy link
Contributor

tamirms commented Dec 6, 2023

There is a bug in the check dependencies script which is causing the "Dependency sanity checker" CI failure. The script relies on the fact that the git and rev properties would be supplied for the stellar-xdr dependency. However, those properties were commented out of the stellar-xdr dependency in the rs-soroban-env repo https://github.com/stellar/rs-soroban-env/blob/main/Cargo.toml#L31-L32 .

@tamirms tamirms added the bug Something isn't working label Dec 6, 2023
@mollykarcher
Copy link
Contributor

Link to slack discussion

We should likely be able to scrap the script (or at least part of it) in favor of cargo-deny, which other rust repos currently use. However, that script is also checking go dependencies (not just rust) to make sure xdr versions match up, so we may need some hybrid or an alternative if that's still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants