Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pagingToken from getEvents #297

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Remove pagingToken from getEvents #297

merged 1 commit into from
Oct 2, 2024

Conversation

psheth9
Copy link
Contributor

@psheth9 psheth9 commented Sep 20, 2024 •
edited
Loading

Delete pagingToken from getEvents. Use Cursor instead.

Note: This is a breaking change !!

Fixes: #118

@psheth9 psheth9 self-assigned this Sep 20, 2024
@psheth9 psheth9 added breaking-change Breaking change tag api-change Any changes to existing API or addition of new API labels Sep 20, 2024
@psheth9 psheth9 marked this pull request as ready for review September 20, 2024 16:33
@psheth9 psheth9 requested review from Shaptic, tamirms and aditya1702 and removed request for Shaptic September 20, 2024 16:34
@mollykarcher
Copy link
Contributor

Shouldn't this be targeted to v22-breaking-changes?

@psheth9 psheth9 changed the base branch from main to v22-breaking-changes September 20, 2024 17:18
2opremio
2opremio reviewed Sep 20, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@Shaptic
Copy link
Contributor

Shaptic commented Sep 20, 2024

@2opremio @mollykarcher maybe I missed this but why do we have a distinction between v22-breaking-changes and protocol-22? I feel like everything in protocol-22 is breaking?

@mollykarcher
Copy link
Contributor

honestly i don't think it was intentional? we definitely only need one

@psheth9 psheth9 requested a review from 2opremio September 23, 2024 23:12
@psheth9 psheth9 merged commit 44db01f into v22-breaking-changes Oct 2, 2024
19 checks passed
@psheth9 psheth9 deleted the remove-pagingtoken-getEvents branch October 2, 2024 15:29
This was referenced Oct 10, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Open
Shaptic added a commit that referenced this pull request Oct 23, 2024
@Shaptic
Revert "Remove pagingToken from getEvents (#297)"
6a7a9d5 
This reverts commit 44db01f.
Shaptic added a commit that referenced this pull request Oct 24, 2024
@Shaptic
Revert "Remove pagingToken from getEvents (#297)"
4b948c3 
This reverts commit 44db01f.
Shaptic added a commit that referenced this pull request Oct 25, 2024
@Shaptic
Add back in Protocol 22 non-breaking changes for a transition period (#…
5932852 
…317)

* Add both versions of getVersionInfo in
* Make createdAt properly non-breaking
* Revert "Remove pagingToken from getEvents (#297)"

This reverts commit 44db01f.

* Ignore the latest version since it matches the one being used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya1702 aditya1702 aditya1702 approved these changes

@tamirms tamirms tamirms approved these changes

@Shaptic Shaptic Awaiting requested review from Shaptic

@2opremio 2opremio Awaiting requested review from 2opremio

Assignees

@psheth9 psheth9

Labels
api-change Any changes to existing API or addition of new API breaking-change Breaking change tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align naming convention to cursor
6 participants
@psheth9 @mollykarcher @Shaptic @tamirms @2opremio @aditya1702