Export functions for creating Timepoint/Duration #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
commented
Jan 8, 2024
graydon
approved these changes
Jan 9, 2024
|
Holding until this other issue is closed: |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Export functions for creating and accessing Timepoint and Duration.
Why
The types are not creatable inside a contract, and outside a contract in tests are only creatable using the XDR ScVal type. If developers are to use the Timepoint and Duration types, they need to be able to construct the types from primitive values.
The
Timepointfrom_unixandto_unixfunctions were added using the unix terminologgy because that's the type of time values the Stellar network uses.The
Durationfrom_secondsandto_secondsfunctions were added using the seconds terminology because it seemed like the most direct way to communicate intent. I originally intended to usesecswhich I think would also be reasonable and feedback on the issue suggestedsecondswhich also seems reasonable to me.While for both types functions were repurposed/removed, those functions were private only and should have no impact on compatibility.
Close #1197