Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Binary to Bytes #385

Closed
leighmcculloch opened this issue Aug 1, 2022 · 1 comment · Fixed by #394 or stellar/stellar-xdr#16
Closed

Rename Binary to Bytes #385

leighmcculloch opened this issue Aug 1, 2022 · 1 comment · Fixed by #394 or stellar/stellar-xdr#16

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented Aug 1, 2022

I think we should consider renaming the Binary type to Bytes.

In Solidity, their binary type uses the terms byte. https://docs.soliditylang.org/en/v0.8.11/types.html#fixed-size-byte-arrays

In Vyper, the new Ethereum lang, their binary type is named Bytes. https://vyper-by-example.org/values/

The term is immediately recognizable and less ambiguous as Binary. Binary can be ambiguous because people more often use the term to refer to executable binaries than they do byte slices. The term byte almost always shows up in any description I've casually given to what a Binary is.

Thoughts @jonjove @sisuresh @paulbellamy @tomerweller ?

@jonjove
Copy link
Contributor

jonjove commented Aug 2, 2022

I'm not picky about this. Either is fine by me. It looks like Bytes is supported by the majority, so let's go for that.

@leighmcculloch leighmcculloch changed the title Decision: Rename Binary to Bytes Rename Binary to Bytes Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants