Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

[1] clean up root.go basic kelp binary invocation logic #568

Closed
nikhilsaraf opened this issue Oct 26, 2020 · 1 comment
Closed

[1] clean up root.go basic kelp binary invocation logic #568

nikhilsaraf opened this issue Oct 26, 2020 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@nikhilsaraf
Copy link
Contributor

nikhilsaraf commented Oct 26, 2020

  • take in isGUI param from command-line (or some other way of figuring out if it's the GUI bot or not)
  • if isGUI, then default operation should be to load kelp server (windows loads with --no-electron)
  • else loads the --help section, with the ASCII art
  • remove the .bat file for windows since we don't need it any longer since we can execute the kelp.exe binary directly to load it in the browser
@nikhilsaraf nikhilsaraf added the bug Something isn't working label Oct 26, 2020
@nikhilsaraf nikhilsaraf changed the title [1] clean up root.go basic kelp binary invocation logic [ad-hoc] [1] clean up root.go basic kelp binary invocation logic Oct 26, 2020
@nikhilsaraf
Copy link
Contributor Author

@debnil forgot to add this task earlier, can you include this in your ad-hoc tasks?

@nikhilsaraf nikhilsaraf added this to the v1.10.1 milestone Nov 16, 2020
@nikhilsaraf nikhilsaraf self-assigned this Jan 17, 2021
@nikhilsaraf nikhilsaraf changed the title [ad-hoc] [1] clean up root.go basic kelp binary invocation logic [1] clean up root.go basic kelp binary invocation logic Jan 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants