This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 262
[Nikhil ad-hoc] [5] (5) Simple Integration test for buysell strategy #51
Labels
feature request
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Milestone
Comments
use hardcoded accounts for now, if testnet is reset anytime we can always circle back to autogenerated accounts. |
Can use testnet for now. If it's easy and computationally inexpensive, can consider using docker quickstart in standalone mode for a "private" network. just start it with two options:
second option may be actually slower because travis has some problem with caching large files. you need to check it out. |
nikhilsaraf
changed the title
Simple integration test needed to confidently merge PR contributions
[8] Simple integration test needed to confidently merge PR contributions
Jun 3, 2020
nikhilsaraf
changed the title
[8] Simple integration test needed to confidently merge PR contributions
[3] Simple Integration test for buysell strategy
Aug 18, 2020
nikhilsaraf
changed the title
[3] Simple Integration test for buysell strategy
[5] Simple Integration test for buysell strategy
Sep 20, 2020
@debnil assigning to myself since I'm working on part of the code that touches this |
nikhilsaraf
changed the title
[5] Simple Integration test for buysell strategy
[5] (5) Simple Integration test for buysell strategy
Oct 22, 2020
nikhilsaraf
changed the title
[5] (5) Simple Integration test for buysell strategy
[Nikhil ad-hoc] [5] (5) Simple Integration test for buysell strategy
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
feature request
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Desired Behavior
Travis test run should fail of the build is unable to start up and trade
Impact
The desired behavior will allow me to confidently merge pull requests without having to sync the code and test locally
Feature Suggestion
We can achieve the desired behavior by having a simple integration test that generates the required accounts, assets, and trustlines, funding, and runs a simple trading strategy.
This should be run as a go test along with all the other existing tests.
Testing against the test network is ok for now (vs. spinning up a new private testnet)
This can run against the buysell strategy
The text was updated successfully, but these errors were encountered: