Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

[13] Implement Metrics in the Kelp GUI #508

Closed
nikhilsaraf opened this issue Sep 17, 2020 · 1 comment
Closed

[13] Implement Metrics in the Kelp GUI #508

nikhilsaraf opened this issue Sep 17, 2020 · 1 comment
Assignees
@nikhilsaraf @debnil
Labels
feature request New feature or request
Milestone
KelpGUI_v1.0.0-rc2

Comments

@nikhilsaraf
Copy link
Contributor

Follow what is described in the doc:
https://docs.google.com/document/d/1R5hU7dSloQHZ0XNZkUrS0LPOr2gLVpteXq5NvR-Fy2k/edit#

This is one of the last items needed to release Kelp GUI rc2
@nikhilsaraf nikhilsaraf added the feature request New feature or request label Sep 17, 2020
@nikhilsaraf nikhilsaraf added this to the KelpGUI_v1.0.0-rc2 milestone Sep 17, 2020
@nikhilsaraf nikhilsaraf changed the title [13] Implement Metrics in the Kelp GUI [21] Implement Metrics in the Kelp GUI Sep 17, 2020
@nikhilsaraf
Copy link
Contributor Author

marked as a 21-pointer because of the number of items that need to be tracked. Can break down into smaller tasks based on the titles in the document, let's discuss in sprint planning when you get to this issue.

@nikhilsaraf nikhilsaraf mentioned this issue Sep 20, 2020
Open
@debnil debnil changed the title [21] Implement Metrics in the Kelp GUI [13] Implement Metrics in the Kelp GUI Oct 13, 2020
@debnil debnil mentioned this issue Nov 3, 2020
Draft
nikhilsaraf pushed a commit that referenced this issue Nov 7, 2020
@debnil
Enable GUI metrics tracking (part of #508) (#549)
31d5520 
* Initial commit

* Create sendMetric route

* Address review - nikhilsaraf

* Fix seconds update metric.

* Address review - nikhilsaraf

* Add tests for metrics tracker.

* Pass time to metrics tracker

* Modify map string interface conversion.

* Address review 3 - nikhilsaraf

* Tweak merge maps test.

* Address final review - nikhilsaraf
@nikhilsaraf nikhilsaraf self-assigned this Jan 17, 2021
nikhilsaraf added a commit that referenced this issue Jan 18, 2021
@nikhilsaraf
Add GUI metrics to Button.js and refactor metrics tracker and fronten…
07e8b1e 
…d metric architecture (part of #508) (#642)

* 1 - changes from existing PR 582

* 2 - changes from my comments on PR

* 3 - pass in correct baseURL to sendMetricEvent from Button.js

* 4 - fix check for metrics when in local dev mode (no metrics tracker)

* 5 - metrics tracker should throw when amplitude returns invalid response

* 6 - fix API usage of /sendMetricEvent

* 7 - warn when no event name on button

* 8 - use correct event name type and data across the frontend, API, backend

* 9 - simplify metrics tracker event props naming

* 10 - refactor and simplify metricsTracker factory methods to use a single factory method

this ensures we do not send cli props for gui actions etc since they are separated

* 11 - prefix gui specific event properties as gui_

* 12 - isTestnet should be hardcoded to true by default

* 13 - change warning when no event name to an error

* 14 - set button names for welcome screen

* 15 - set button names for all remaining buttons by threading eventPrefix

* 16 - rename event_name to gui_event_name

* 17 - fix warnings in Button.js
@nikhilsaraf nikhilsaraf mentioned this issue Mar 15, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nikhilsaraf nikhilsaraf

@debnil debnil

Labels
feature request New feature or request
Projects
None yet
Milestone
KelpGUI_v1.0.0-rc2
Development

No branches or pull requests
2 participants
@nikhilsaraf @debnil