Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

[ad-hoc] [3](5) Add test for volumeFilter to ensure we correctly handle offers that will put us over #483

Closed
nikhilsaraf opened this issue Aug 21, 2020 · 1 comment · Fixed by #585
Closed

[ad-hoc] [3](5) Add test for volumeFilter to ensure we correctly handle offers that will put us over #483

nikhilsaraf opened this issue Aug 21, 2020 · 1 comment · Fixed by #585
Assignees
@debnil
Labels
bug Something isn't working
Milestone
v1.11.0

Comments

@nikhilsaraf
Copy link
Contributor

nikhilsaraf commented Aug 21, 2020 •
edited
Loading

use tests in dailyVolumeByDate_test.go and TestMakeVolumeFilterConfig as inspiration.
@nikhilsaraf nikhilsaraf added the bug Something isn't working label Aug 21, 2020
@nikhilsaraf nikhilsaraf added this to the v1.10.0 milestone Aug 21, 2020
@nikhilsaraf nikhilsaraf self-assigned this Aug 21, 2020
@nikhilsaraf nikhilsaraf changed the title [1] Add test for volumeFilter to ensure we correctly handle offers that will put us over [3] Add test for volumeFilter to ensure we correctly handle offers that will put us over Sep 14, 2020
@debnil debnil self-assigned this Oct 13, 2020
@nikhilsaraf nikhilsaraf modified the milestones: v1.10.0, KaaS v1.0 Oct 13, 2020
@nikhilsaraf nikhilsaraf removed their assignment Oct 13, 2020
@nikhilsaraf
Copy link
Contributor Author

@debnil moved this to Next Sprint in planning so we can prioritize v1.10.0 release this sprint

@nikhilsaraf nikhilsaraf mentioned this issue Oct 20, 2020
Closed
@nikhilsaraf nikhilsaraf modified the milestones: KaaS v1.0, v1.10.1 Oct 20, 2020
@debnil debnil mentioned this issue Oct 23, 2020
Merged
@nikhilsaraf nikhilsaraf changed the title [3] Add test for volumeFilter to ensure we correctly handle offers that will put us over [ad-hoc] [3] Add test for volumeFilter to ensure we correctly handle offers that will put us over Oct 26, 2020
@debnil debnil changed the title [ad-hoc] [3] Add test for volumeFilter to ensure we correctly handle offers that will put us over [ad-hoc] [3](5) Add test for volumeFilter to ensure we correctly handle offers that will put us over Oct 26, 2020
nikhilsaraf pushed a commit that referenced this issue Nov 12, 2020
@debnil
Add tests for the volume filter (part of #483) (#552)
1929b86 
* Initial commit - test constructor.

* Add tests to filter fn.

* Rename createFloat to createFloatPtr.

* Fix capitalization error.

* Rewrite most of the tests - still need to eliminate a couple of structs.

* Change test interface.

* Address review 2 - nikhilsaraf

* Modify volumeFilterFn parameters, change market ID query slice logic

* Remove log

* Factor out action.

* Move query market IDs creation, add comments

* Pair programming commit.

* Delete volume filter fn test.

* Remove unused helper, add default configValue
@debnil debnil mentioned this issue Nov 12, 2020
Merged
nikhilsaraf pushed a commit that referenced this issue Nov 18, 2020
@debnil
Add test for volume filter function (closes #483) (#585)
d2b1e48 
* Initial commit

* Add readability fixes

* Remove dupe tests, change assert
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@debnil debnil

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging a pull request may close this issue.

Add test for volume filter function (closes #483) debnil/kelp
2 participants
@nikhilsaraf @debnil