Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

[8](13) Improve data tracking for Kelp CLI #478

Closed
nikhilsaraf opened this issue Aug 18, 2020 · 0 comments · Fixed by #513
Closed

[8](13) Improve data tracking for Kelp CLI #478

nikhilsaraf opened this issue Aug 18, 2020 · 0 comments · Fixed by #513
Assignees
@debnil
Labels
feature request New feature or request
Milestone
v1.10.0

Comments

@nikhilsaraf
Copy link
Contributor

nikhilsaraf commented Aug 18, 2020 •
edited
Loading

This is dependent on the outcome from the Spike #477

Outcome is to use Amplitude

See this doc for details on what to track: https://docs.google.com/document/d/1R5hU7dSloQHZ0XNZkUrS0LPOr2gLVpteXq5NvR-Fy2k

Follow-on issues to be handled as separate tasks: #516
@nikhilsaraf nikhilsaraf added the feature request New feature or request label Aug 18, 2020
@nikhilsaraf nikhilsaraf added this to the v1.10.0 milestone Aug 18, 2020
@nikhilsaraf nikhilsaraf assigned nikhilsaraf and debnil and unassigned nikhilsaraf Aug 18, 2020
@debnil debnil changed the title [3] Improve data tracking for Kelp [8] Improve data tracking for Kelp Aug 31, 2020
@nikhilsaraf nikhilsaraf changed the title [8] Improve data tracking for Kelp [8] Improve data tracking for Kelp CLI Sep 14, 2020
@debnil debnil mentioned this issue Sep 25, 2020
Merged
@nikhilsaraf nikhilsaraf mentioned this issue Sep 29, 2020
Closed
8 tasks
nikhilsaraf pushed a commit that referenced this issue Oct 9, 2020
@debnil
Set up CLI data tracking, closes #478 (#513)
3fc5332 
* Initial commit

* Address review - nikhilsaraf

* Add tracker event details

* Misc fixes

* Change glide.lock

* Remove echo amplitude api key

* Make review changes - nikhilsaraf

* Address review 2 - nikhilsaraf

* Make Amplitude non-functional

* Address final review - nikhilsaraf

* Fix error handling.

* 1 - censor API Key when logging

* 2 - fix response checking for success

* 3 - fix session_id based on amplitude format

should be on the event instead of on the event properties based o the documentation

https://help.amplitude.com/hc/en-us/articles/360032842391-HTTP-API-V2#http-api-v2-events

* 4 - revert glide.yaml and glide.lock to remove github.com/google/uuid

reverted glide.lock to 69b38e3~1

* 5 - update message in build script to follow pattern of other warning messages with force option set

* 6 - clean up logs, stronger disabled check, TODO for sdk
@debnil debnil changed the title [8] Improve data tracking for Kelp CLI [8](13) Improve data tracking for Kelp CLI Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@debnil debnil

Labels
feature request New feature or request
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

Set up CLI data tracking stellar-deprecated/kelp
2 participants
@nikhilsaraf @debnil