Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

[2](3) Kelp GUI: disallow invalid characters in bot name #429

Closed
nikhilsaraf opened this issue Jun 2, 2020 · 0 comments · Fixed by #520
Closed

[2](3) Kelp GUI: disallow invalid characters in bot name #429

nikhilsaraf opened this issue Jun 2, 2020 · 0 comments · Fixed by #520
Assignees
@debnil
Labels
bug Something isn't working good first issue Good for newcomers GUI issues related to the Kelp GUI
Milestone
KelpGUI_v1.0.0-rc2

Comments

@nikhilsaraf
Copy link
Contributor

Description

When naming a bot with characters such as < and or > it attempts to create a file with that name and also remove that file when deleting which fails:

error running rm command for bot configs: error in bash command 'rm /Users/user/.kelp/bot_data/configs/usd_<>_xlm*' for namespace 'rm': (eWait=exit status 1, outputBytes=, eRead=<nil>)

We should disallow names that would be invalid in the validation function on the server, simple fix for now.

Your Environment

Kelp GUI
@nikhilsaraf nikhilsaraf added bug Something isn't working GUI issues related to the Kelp GUI labels Jun 2, 2020
@nikhilsaraf nikhilsaraf added this to the KelpGUI_v1.0.0-rc2 milestone Jun 2, 2020
@nikhilsaraf nikhilsaraf self-assigned this Jun 2, 2020
@nikhilsaraf nikhilsaraf added the good first issue Good for newcomers label Jun 3, 2020
@nikhilsaraf nikhilsaraf changed the title Kelp GUI: disallow invalid characters in bot name [1] Kelp GUI: disallow invalid characters in bot name Jun 3, 2020
@nikhilsaraf nikhilsaraf assigned debnil and unassigned nikhilsaraf Aug 18, 2020
@debnil debnil changed the title [1] Kelp GUI: disallow invalid characters in bot name [2] Kelp GUI: disallow invalid characters in bot name Aug 31, 2020
@debnil debnil mentioned this issue Oct 1, 2020
Merged
debnil added a commit that referenced this issue Oct 7, 2020
@debnil
Disallow invalid characters in bot name (closes #429)
3de242e 
PR #520 

* Initial commit

* Initial commit

* Add test

* Remove TODOs

* Address review - nikhilsaraf

* Fix CI failure.

* Throw error on double initialization.
@debnil debnil changed the title [2] Kelp GUI: disallow invalid characters in bot name [2](3) Kelp GUI: disallow invalid characters in bot name Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@debnil debnil

Labels
bug Something isn't working good first issue Good for newcomers GUI issues related to the Kelp GUI
Projects
None yet
Milestone
KelpGUI_v1.0.0-rc2
Development

Successfully merging a pull request may close this issue.

Disallow invalid characters in bot name (closes #429) stellar-deprecated/kelp
2 participants
@nikhilsaraf @debnil